fix(Instrumentation/Routing): handle array controller for reflection on attribute parsing (#182)

* fix(Instrumentation/Routing): handle array controller for reflection on attribute parsing

* chore: format

Author: gaelreyrol

src/Instrumentation/Symfony/Framework/Routing/TraceableRouteLoader.php

@@ -57,7 +57,9 @@ private static function parseAttribute(Route $route): void
     {
         try {
             $controller = $route->getDefault('_controller');
-            if (true === str_contains($controller, '::')) {
+            if (is_array($controller) && 2 === count($controller)) {
+                $reflection = new \ReflectionMethod(sprintf('%s::%s', $controller[0], $controller[1]));
+            } elseif (true === str_contains($controller, '::')) {
                 $reflection = new \ReflectionMethod($controller);
             } else {
                 $reflection = new \ReflectionClass($controller);

tests/Functional/Application/config/routes/routes.php

@@ -0,0 +1,10 @@
+<?php
+
+use App\Controller\Traceable\ActionTraceableController;
+use Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator;
+
+return static function (RoutingConfigurator $routingConfigurator): void {
+    $routingConfigurator->add('php-config', '/php-config')
+        ->controller([ActionTraceableController::class, 'phpConfig'])
+        ->methods(['GET']);
+};

tests/Functional/Application/src/Controller/Traceable/ActionTraceableController.php

@@ -120,4 +120,12 @@ public function logSpanContext(LoggerInterface $logger): Response
             'status' => 'ok',
         ]);
     }
+
+    #[Traceable]
+    public function phpConfig(): Response
+    {
+        return $this->json([
+            'status' => 'ok',
+        ]);
+    }
 }

tests/Functional/Instrumentation/HttpKernel/HttpKernelAttributeTracingTest.php

@@ -459,4 +459,35 @@ public function testLogWithSpanContext(): void
 
         self::assertLogHasSpanContext($log, $mainSpan);
     }
+
+    public function testPhpConfig(): void
+    {
+        $client = static::createClient();
+        $client->request('GET', '/php-config');
+
+        static::assertResponseIsSuccessful();
+        static::assertSame('{"status":"ok"}', $client->getResponse()->getContent());
+
+        self::assertSpansCount(1);
+
+        $mainSpan = self::getSpans()[0];
+        self::assertSpanName($mainSpan, 'php-config');
+        self::assertSpanStatus($mainSpan, StatusData::ok());
+        self::assertSpanAttributes($mainSpan, [
+            'url.full' => 'http://localhost/php-config',
+            'http.request.method' => 'GET',
+            'url.path' => '/php-config',
+            'symfony.kernel.http.host' => 'localhost',
+            'url.scheme' => 'http',
+            'network.protocol.version' => '1.1',
+            'user_agent.original' => 'Symfony BrowserKit',
+            'network.peer.address' => '127.0.0.1',
+            'symfony.kernel.net.peer_ip' => '127.0.0.1',
+            'server.address' => 'localhost',
+            'server.port' => 80,
+            'http.route' => 'php-config',
+            'http.response.status_code' => Response::HTTP_OK,
+        ]);
+        self::assertSpanEventsCount($mainSpan, 0);
+    }
 }