Enrich the trace with information from the HTTP-response in TraceableResponse

[Kaspiman]

What if we add the response body/content as an attribute in the span? This would help us see the result of the request exactly.

[gaelreyrol]

Hi @Kaspiman,

I would not recommend to do that in most cases, especially as a default behavior, for several reasons:

• security/privacy, you might not want to capture response body because it might expose sensitive data
• performance, heavy responses might affect trace performances on the collect/storage/visualization side
• content type, handling each content type would require a huge amount of work

Check out this issue : open-telemetry/semantic-conventions#857

That being said, I would implement it as an opt-in feature where I would have to specify how to capture it and parse it, like a handler or through an event subscriber, for example.

It would be called while the instrumentation is done, it would allow us to not only add the response body as a span attribute but also add anything we want.

WDYT ?

[Kaspiman]

Your arguments are quite compelling. Maybe we should just use logging instead of traces in this case?

[gaelreyrol]

Your arguments are quite compelling. Maybe we should just use logging instead of traces in this case?

You can always log it yourself (within the app side), and even use the monolog integration of this package to forward your logs to your open telemetry collector. It should be possible to correlate logs with traces according to this specification: https://opentelemetry.io/docs/specs/otel/logs/#log-correlation.

Still, I think it would be interesting to provide a way to enrich yourself spans created by the instrumentation based on the context of the instrumentation. It is not absolutely necessary but I think it would be a great feature.