Skip to content

fix(Instrumentation/Routing): handle array controller for reflection on attribute parsing#182

Merged
gaelreyrol merged 2 commits into
FriendsOfOpenTelemetry:mainfrom
gaelreyrol:fix/route-loader-controller-array
Jun 20, 2025
Merged

fix(Instrumentation/Routing): handle array controller for reflection on attribute parsing#182
gaelreyrol merged 2 commits into
FriendsOfOpenTelemetry:mainfrom
gaelreyrol:fix/route-loader-controller-array

Conversation

@gaelreyrol
Copy link
Copy Markdown
Contributor

@gaelreyrol gaelreyrol commented Jun 20, 2025

This PR closes #180, #166 .

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (b438205) to head (7aea2ac).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #182   +/-   ##
=========================================
  Coverage     91.26%   91.27%           
- Complexity      681      683    +2     
=========================================
  Files           116      116           
  Lines          2806     2808    +2     
=========================================
+ Hits           2561     2563    +2     
  Misses          245      245           
Flag Coverage Δ
phpunit 91.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaelreyrol gaelreyrol merged commit 94f85a0 into FriendsOfOpenTelemetry:main Jun 20, 2025
9 checks passed
@gaelreyrol gaelreyrol deleted the fix/route-loader-controller-array branch June 20, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TraceableRouteLoader – a bug occurs when trying to load a route definition using the PHP file format.

1 participant