feat: Add StructureTree navigation as off-canvas sidebar#194
Closed
skerbis wants to merge 5 commits into
Closed
Conversation
- Add new StructureTreeButton with modern off-canvas design - Implement accordion-style navigation with three-dot toggles - Add status indicators for online/offline/gesperrt categories - Include live search functionality with clear button - Add expand/collapse all feature with intelligent toggle - Support dark/light theme with Dashboard2 CSS pattern - Add glassmorphic design with backdrop effects - Include comprehensive German and English translations - Auto-expand current category path for better UX - Responsive design for various screen sizes
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Structure Tree navigation component as an off-canvas sidebar to provide a hierarchical view of the site structure. The implementation includes modern UI patterns, theme support, search functionality, and comprehensive internationalization.
- Adds a new StructureTreeButton with off-canvas sidebar design and accordion-style navigation
- Implements live search functionality with status indicators for online/offline/locked categories
- Provides comprehensive theming support for both light and dark themes with glassmorphic design effects
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/QuickNavigation/Utility/BuildNavigationArray.php | Adds status field to navigation array for category state tracking |
| lib/QuickNavigation/Button/YformButton.php | Simplifies YForm availability check logic |
| lib/QuickNavigation/Button/StructureTreeButton.php | New button implementation with tree rendering and off-canvas functionality |
| lang/en_gb.lang | Adds English translations for structure tree UI elements |
| lang/de_de.lang | Adds German translations for structure tree UI elements |
| fragments/QuickNavigation/StructureTreeList.php | Fragment template for rendering tree list structure |
| fragments/QuickNavigation/StructureTreeButton.php | Fragment template for off-canvas sidebar with search and controls |
| boot.php | Registers new StructureTreeButton in the button registry |
| assets/quick-navigation.js | Adds comprehensive JavaScript for off-canvas functionality and tree interactions |
| assets/quick-navigation.css | Extensive CSS for theming, animations, and responsive design |
| .php-cs-fixer.cache | Updated code style cache file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| // Icon auf "expand" ändern | ||
| $icon.removeClass('fa-compress-arrows-alt').addClass('fa-expand-arrows-alt'); | ||
| $toggleBtn.attr('title', 'Alle aufklappen'); |
There was a problem hiding this comment.
Hardcoded German text 'Alle aufklappen' should use i18n translation or be localized properly. This breaks internationalization for non-German users.
|
|
||
| // Icon auf "collapse" ändern | ||
| $icon.removeClass('fa-expand-arrows-alt').addClass('fa-compress-arrows-alt'); | ||
| $toggleBtn.attr('title', 'Alle zuklappen'); |
There was a problem hiding this comment.
Hardcoded German text 'Alle zuklappen' should use i18n translation or be localized properly. This breaks internationalization for non-German users.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental