Some refactor and better documentation#172
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #171 by preventing disabled for_* plugins from being loaded/initialized via external_plugins, and it refactors the build pipeline/docs so custom plugins are no longer mirrored into the upstream TinyMCE vendor tree.
Changes:
- Filter
external_pluginsat runtime to only include plugins enabled in the profile’splugins:list (fixes #171). - Update build/sync/clean scripts + plugin workspace
build-copyscripts to stop writing custom plugins intoassets/vendor/tinymce/plugins/and clean historical leftovers. - Refactor parts of
for_images(clipboard/delete helpers, DOM traversal) and change the “swap from mediapool” button to delegate to TinyMCE’s image dialog.
Reviewed changes
Copilot reviewed 33 out of 99 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/sync-build-to-assets.js | Document and enforce syncing staged build output into assets/ without mirroring custom plugins into vendor. |
| scripts/clean-build.js | Remove build/ and delete stray custom plugin folders from assets/vendor/tinymce/plugins/. |
| scripts/build-plugins.js | Refactor custom-plugin build pipeline; staging output support; stop writing into vendor tree. |
| package.yml | Bump addon version to 8.10.3. |
| lib/TinyMce/Provider/Assets.php | Add profile builder CSS and new i18n key for the for_images coupling hint. |
| lang/sv_se.lang | Update “imagewidth” section wording and add tinymce_imagewidth_plugin_hint. |
| lang/en_gb.lang | Update “imagewidth” section wording and add tinymce_imagewidth_plugin_hint. |
| lang/de_de.lang | Update “imagewidth” section wording and add tinymce_imagewidth_plugin_hint. |
| custom_plugins/snippets/package.json | Stop copying plugin dist into assets/vendor/tinymce/plugins/. |
| custom_plugins/quote/package.json | Stop copying plugin dist into assets/vendor/tinymce/plugins/. |
| custom_plugins/phonelink/package.json | Stop copying plugin dist into assets/vendor/tinymce/plugins/. |
| custom_plugins/mediapaste/package.json | Stop copying plugin dist into assets/vendor/tinymce/plugins/. |
| custom_plugins/link_yform/package.json | Stop copying plugin dist into assets/vendor/tinymce/plugins/. |
| custom_plugins/for_video/package.json | Stop copying plugin dist into assets/vendor/tinymce/plugins/. |
| custom_plugins/for_toc/package.json | Stop copying plugin dist into assets/vendor/tinymce/plugins/. |
| custom_plugins/for_oembed/package.json | Stop copying plugin dist into assets/vendor/tinymce/plugins/. |
| custom_plugins/for_markdown/package.json | Stop copying plugin dist into assets/vendor/tinymce/plugins/. |
| custom_plugins/for_images/src/main/ts/Plugin.ts | Internal refactor + delegate mediapool swap to mceImage. |
| custom_plugins/for_images/package.json | Stop copying plugin dist into assets/vendor/tinymce/plugins/. |
| custom_plugins/for_htmlembed/package.json | Stop copying plugin dist into assets/vendor/tinymce/plugins/. |
| custom_plugins/for_footnotes/package.json | Stop copying plugin dist into assets/vendor/tinymce/plugins/. |
| custom_plugins/for_checklist/package.json | Stop copying plugin dist into assets/vendor/tinymce/plugins/. |
| custom_plugins/for_chars_symbols/package.json | Stop copying plugin dist into assets/vendor/tinymce/plugins/. |
| custom_plugins/for_abbr/package.json | Stop copying plugin dist into assets/vendor/tinymce/plugins/. |
| custom_plugins/for_a11y/package.json | Stop copying plugin dist into assets/vendor/tinymce/plugins/. |
| custom_plugins/cleanpaste/package.json | Stop copying plugin dist into assets/vendor/tinymce/plugins/. |
| CHANGELOG.md | Add 8.10.3 entry describing fixes and build-pipeline changes. |
| assets/vendor/tinymce/plugins/snippets/plugin.min.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/snippets/plugin.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/quote/version.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/quote/plugin.min.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/quote/plugin.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/quote/LICENSE.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/quote/langs/de.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/quote/CHANGELOG.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/phonelink/version.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/phonelink/plugin.min.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/phonelink/plugin.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/phonelink/LICENSE.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/phonelink/langs/de.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/phonelink/CHANGELOG.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/mediapaste/version.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/mediapaste/plugin.min.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/mediapaste/plugin.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/link_yform/version.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/link_yform/plugin.min.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/link_yform/plugin.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/link_yform/LICENSE.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/link_yform/CHANGELOG.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_video/version.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_video/plugin.min.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_video/plugin.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_toc/version.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_toc/plugin.min.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_toc/plugin.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_oembed/version.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_oembed/plugin.min.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_oembed/plugin.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_markdown/version.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_images/version.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_images/plugin.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_images/LICENSE.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_images/CHANGELOG.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_htmlembed/version.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_htmlembed/plugin.min.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_htmlembed/plugin.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_footnotes/version.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_footnotes/plugin.min.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_footnotes/plugin.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_checklist/version.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_checklist/plugin.min.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_checklist/plugin.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_chars_symbols/version.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_abbr/version.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_abbr/plugin.min.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_abbr/plugin.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/for_a11y/version.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/cleanpaste/version.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/cleanpaste/plugin.min.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/cleanpaste/plugin.js | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/cleanpaste/LICENSE.txt | Remove custom plugin artifact from vendor tree. |
| assets/vendor/tinymce/plugins/cleanpaste/CHANGELOG.txt | Remove custom plugin artifact from vendor tree. |
| assets/scripts/base.js | Filter external_plugins against the profile’s active plugin list (fixes #171). |
| assets/css/profile_builder.css | New styling for the profile assistant UI (light/dark). |
Files not reviewed (1)
- assets/scripts/tinymce/plugins/for_images/plugin.js: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed: #171