Skip to content

Fix WAVE accessibility errors for local video generation #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skerbis merged 3 commits into from
Oct 10, 2025
Merged

Fix WAVE accessibility errors for local video generation #47

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0144f1b
Initial plan
Copilot Oct 1, 2025
7c9629a
Fix WAVE accessibility errors for local videos
Copilot Oct 1, 2025
80814c9
Update lib/video.php
skerbis Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/video.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,14 +382,19 @@ public function generate(): string
// Never set src attribute for YouTube/Vimeo - this should be done by JavaScript after consent
} else {
$code .= " src=\"" . rex_escape($sourceUrl) . "\"";
// Add aria-label for local videos/audio to ensure proper accessibility
$ariaLabel = $this->title ?: $this->getText("a11y_{$mediaType}_player");
Comment thread
skerbis marked this conversation as resolved.
$code .= " aria-label=\"" . rex_escape($ariaLabel) . "\"";
}

$code .= " crossorigin>";

$code .= "<media-provider>";

if (!$isAudio && !empty($this->poster)) {
$code .= "<media-poster class=\"vds-poster\" src=\"" . rex_escape($this->poster['src']) . "\" alt=\"" . rex_escape($this->poster['alt']) . "\"></media-poster>";
// Use title as fallback alt text if poster alt is empty for accessibility
$posterAlt = !empty($this->poster['alt']) ? $this->poster['alt'] : (!empty($this->title) ? $this->title : $this->getText('a11y_video_poster'));
$code .= "<media-poster class=\"vds-poster\" src=\"" . rex_escape($this->poster['src']) . "\" alt=\"" . rex_escape($posterAlt) . "\"></media-poster>";
}

if ($videoInfo['platform'] === 'default') {
Expand Down