Feat: see all performance settings / toggle done settings

[zukucker]

Hey,

tried my best to implement a solution for #360 .
Please let me know if if i can do anything better.

[schneider-felix]

Looks good to me.

I think it could be a bit better if you refactored the checkers a bit. Instead of adding an else clause to each checker, I would add a new static function to SettingsResult.

Theoretically you could also add a constructor to SettingsResult, but that would be a breaking change and I know that there are people who use this class in their plugins.

So I would do it like this:
Add a new static function SettingsResult::create() which takes the same parameters as the other static functions but also additionally takes the state as the first parameter. With that, you can simply remove the if-else clause from the checkers and use the SettingsResult::create() function instead.

[zukucker]

Hi, thank you - way better solution. You are absolute right. ill do it asap 👍

[lacknere]

You should use a snippet here :)

[shyim]

@claude can you take over this branch and fix conflicts

[zukucker]

Should i carry on with the snippet / conflicts?

[greptile-apps]

Greptile Summary

This PR adds a done-settings view for performance checks. The main changes are:

• Performance checkers now emit completed rows with STATE_OK.
• The admin performance table can hide or show completed rows.
• Completed rows now include current and recommended values.
• Queue and Redis-related completed rows were updated to display clearer values.

Confidence Score: 5/5

This looks safe to merge.

• No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
src/Components/Health/Checker/PerformanceChecker/FixCacheIdSetChecker.php	The cache-id checker now reports the configured and missing states consistently.
src/Components/Health/Checker/PerformanceChecker/FineGrainedCachingChecker.php	The fine-grained caching checker now uses the actual cache-tagging state for completed rows.
src/Components/Health/Checker/PerformanceChecker/MessengerAutoSetupChecker.php	The messenger auto-setup checker now reports the actual transport auto-setup state.
src/Components/Health/Checker/PerformanceChecker/ProductStreamIndexingChecker.php	The product stream indexing checker now reports the actual enabled or disabled state.
src/Components/Health/Checker/PerformanceChecker/QueueConnectionChecker.php	The queue checker now emits one row for each adapter state and gives healthy adapters a visible name.
src/Components/Health/Checker/PerformanceChecker/RedisTagAwareChecker.php	The Redis tag-aware checker now reports the actual HTTP cache adapter type.
src/Resources/app/administration/src/module/frosh-tools/component/frosh-tools-tab-index/index.js	The admin component now filters completed performance rows unless the user enables the show-done toggle.
src/Resources/app/administration/src/module/frosh-tools/component/frosh-tools-tab-index/template.twig	The performance panel now renders counts, empty state, and rows from the filtered performance list.

_{Reviews (2): Last reviewed commit: "fix: address performance settings review" | Re-trigger Greptile}