Fix MimeTypeTest for Symfony 7.4#2423
Merged
goetas merged 1 commit intoDec 20, 2025
Merged
Conversation
Contributor
Author
|
@nicolas-grekas is there any other mechanic in Symfony to reset |
Contributor
Author
|
think the CI errors are unrelated to the changes @goetas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually soap is added to the root mime types supported so the test will fail.
symfony/symfony#61267
While adopting the tests I stumbled over that actually the previous tests has side effects because the
Request::$formatsis a static variable which is keept between the difference test. To workaround I did go with_1here so not reuse some from the previous test.