Skip to content

Move doctrine/doctrine-bundle to required section#2780

Closed
devtronic wants to merge 1 commit intoFriendsOfSymfony:masterfrom
devtronic:master
Closed

Move doctrine/doctrine-bundle to required section#2780
devtronic wants to merge 1 commit intoFriendsOfSymfony:masterfrom
devtronic:master

Conversation

@devtronic
Copy link
Copy Markdown

Move doctrine/doctrine-bundle to required section to support Symfony Flex resp. Symfony 4

Problem without this change:
https://travis-ci.org/symfony/recipes-contrib/jobs/365738795

Recipe PR:
symfony/recipes-contrib#345

@Nyholm
Copy link
Copy Markdown

Nyholm commented May 6, 2018

Any updates here?

@xabbuh
Copy link
Copy Markdown
Member

xabbuh commented May 6, 2018

This will unnecessarily install the DoctrineBundle even if one does not want to use the bundle with Doctrine ORM.

@devtronic
Copy link
Copy Markdown
Author

devtronic commented May 6, 2018

Symfony standard also requires the doctrine-bundle by default https://github.com/symfony/symfony-standard/blob/3.4/composer.json

Is it Instead of this change possible to add a "noop" database service and wire this as the default?

@xabbuh
Copy link
Copy Markdown
Member

xabbuh commented May 7, 2018

The difference is that the composer.json file of the Symfony Standard Edition will be the composer.json file of your application which means that you will be able to modify it according to your needs. You cannot (easily) do the same with the dependencies that are pulled in by one of your dependencies.

@devtronic
Copy link
Copy Markdown
Author

Ok, I understand. I'll check if there is another way to solve that problem.

@covex-nn
Copy link
Copy Markdown

covex-nn commented May 7, 2018

@devtronic i've already created a PR for "noop database service", see #2708. I suggested to make db_driver parameter optional there. May be you will find another way how to solve a problem with doctrine service, they say that my suggestion feels like a hack =)

@XWB
Copy link
Copy Markdown
Member

XWB commented May 14, 2018

I agree with @xabbuh, we should not make Doctrine Bundle required.

@XWB XWB closed this May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants