Move doctrine/doctrine-bundle to required section#2780
Move doctrine/doctrine-bundle to required section#2780devtronic wants to merge 1 commit intoFriendsOfSymfony:masterfrom devtronic:master
doctrine/doctrine-bundle to required section#2780Conversation
|
Any updates here? |
|
This will unnecessarily install the DoctrineBundle even if one does not want to use the bundle with Doctrine ORM. |
|
Symfony standard also requires the doctrine-bundle by default https://github.com/symfony/symfony-standard/blob/3.4/composer.json Is it Instead of this change possible to add a "noop" database service and wire this as the default? |
|
The difference is that the |
|
Ok, I understand. I'll check if there is another way to solve that problem. |
|
@devtronic i've already created a PR for "noop database service", see #2708. I suggested to make |
|
I agree with @xabbuh, we should not make Doctrine Bundle required. |
Move
doctrine/doctrine-bundleto required section to support Symfony Flex resp. Symfony 4Problem without this change:
https://travis-ci.org/symfony/recipes-contrib/jobs/365738795
Recipe PR:
symfony/recipes-contrib#345