Skip to content

feat(theming): Full Skins & Themes Implementation (#369) #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csharpfritz merged 5 commits into from
Mar 28, 2026

feat(theming): Add ThemeMode and sub-style sample demos with acceptan…

27d4be9
Select commit
Loading
Failed to load commit list.
Merged

feat(theming): Full Skins & Themes Implementation (#369) #528

feat(theming): Add ThemeMode and sub-style sample demos with acceptan…
27d4be9
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Mar 28, 2026 in 3s

19 new alerts

New alerts in code changed by this pull request

  • 8 warnings
  • 11 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 144 in src/BlazorWebFormsComponents.Test/Theming/CssBundlingTests.razor

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning test

This assignment to
cut
Loading
is useless, since its value is never read.

Check warning on line 278 in src/BlazorWebFormsComponents.Test/Theming/JsonThemeLoaderTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning test

Variable
skin.BorderWidth
Loading
may be null at this access because it has a nullable type.

Check warning on line 281 in src/BlazorWebFormsComponents.Test/Theming/JsonThemeLoaderTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning test

Variable
skin.Height
Loading
may be null at this access because it has a nullable type.

Check warning on line 283 in src/BlazorWebFormsComponents.Test/Theming/JsonThemeLoaderTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning test

Variable
skin.Width
Loading
may be null at this access because it has a nullable type.

Check warning on line 239 in src/BlazorWebFormsComponents.Test/Theming/SkinFileParserTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning test

Variable
skin.BorderWidth
Loading
may be null at this access because it has a nullable type.

Check warning on line 298 in src/BlazorWebFormsComponents.Test/Theming/SkinFileParserTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning test

Variable
skin.Width
Loading
may be null at this access because it has a nullable type.

Check warning on line 300 in src/BlazorWebFormsComponents.Test/Theming/SkinFileParserTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning test

Variable
skin.Height
Loading
may be null at this access because it has a nullable type.

Check warning on line 111 in src/BlazorWebFormsComponents.Test/Theming/SubStyleTests.razor

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning test

This assignment to
explicitHeaderStyle
Loading
is useless, since its value is never read.

Check notice on line 156 in src/BlazorWebFormsComponents.Test/Theming/SubStyleTests.razor

See this annotation in the file changed.

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.

Check notice on line 157 in src/BlazorWebFormsComponents.Test/Theming/SubStyleTests.razor

See this annotation in the file changed.

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.

Check notice on line 58 in src/BlazorWebFormsComponents/ServiceCollectionExtensions.cs

See this annotation in the file changed.

Code scanning / CodeQL

Call to 'System.IO.Path.Combine' may silently drop its earlier arguments Note

Call to 'System.IO.Path.Combine' may silently drop its earlier arguments.

Check notice on line 55 in src/BlazorWebFormsComponents/Theming/SkinFileParser.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 110 in src/BlazorWebFormsComponents/Theming/SkinFileParser.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 156 in src/BlazorWebFormsComponents/Theming/SkinFileParser.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 219 in src/BlazorWebFormsComponents/Theming/SkinFileParser.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 270 in src/BlazorWebFormsComponents/Theming/SkinFileParser.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 295 in src/BlazorWebFormsComponents/Theming/SkinFileParser.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 394 in src/BlazorWebFormsComponents/Theming/SkinFileParser.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 224 in src/BlazorWebFormsComponents/Theming/ThemeDiagnostics.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed opportunity to use Where Note

This foreach loop
implicitly filters its target sequence
Loading
- consider filtering the sequence explicitly using '.Where(...)'.