feat: integrate custom detection rule operations and update secure score resource handling

Author: FrodeHus

nodes/Msgraphsecurity/Msgraphsecurity.node.ts

@@ -1,6 +1,6 @@
 import { NodeConnectionTypes, type INodeType, type INodeTypeDescription } from 'n8n-workflow';
 import { secureScoreDescription } from './resources/secureScore';
-import { getManySecureScoreDescription } from './resources/secureScore/getMany';
+import { detectionRuleDescription } from './resources/detectionRule';
 
 export class Msgraphsecurity implements INodeType {
 	description: INodeTypeDescription = {
@@ -32,6 +32,11 @@ export class Msgraphsecurity implements INodeType {
 				type: 'options',
 				noDataExpression: true,
 				options: [
+					{
+						name: 'Custom Detection Rule',
+						value: 'customDetectionRule',
+						description: 'Operations on custom detection rules',
+					},
 					{
 						name: 'Secure Score',
 						value: 'secureScore',
@@ -41,7 +46,7 @@ export class Msgraphsecurity implements INodeType {
 				default: 'secureScore',
 			},
 			...secureScoreDescription,
-			...getManySecureScoreDescription,
+			...detectionRuleDescription,
 		],
 	};
 }

nodes/Msgraphsecurity/resources/detectionRule/getAll.ts

@@ -2,9 +2,9 @@ import { INodeProperties } from "n8n-workflow";
 import { commonOdataProperties } from "../../shared/odataProperties";
 
 const showOnlyIfResourceIsGetAllDetectionRule = {
-    operation: ['getAll'],
-    resource: ['detectionRule'],
-}
+	resource: ['customDetectionRule'],
+	operation: ['getAll'],
+};
 
 export const getAllDetectionRuleDescription: INodeProperties[] = [
 	{

nodes/Msgraphsecurity/resources/detectionRule/index.ts

@@ -2,9 +2,10 @@ import { INodeProperties } from 'n8n-workflow';
 import { getOneDetectionRuleDescription } from './getOne';
 import { createDetectionRuleDescription } from './create';
 import { deleteDetectionRuleDescription } from './delete';
+import { getAllDetectionRuleDescription } from './getAll';
 
 const showIfDetectionRuleOperation = {
-	operation: ['detectionRule'],
+	resource: ['customDetectionRule'],
 };
 
 export const detectionRuleDescription: INodeProperties[] = [
@@ -25,7 +26,7 @@ export const detectionRuleDescription: INodeProperties[] = [
 				routing: {
 					request: {
 						method: 'GET',
-						url: '/security/rules/detectionRules/{{ $parameter.detectionRuleId }}',
+						url: '/rules/detectionRules/{{ $parameter.detectionRuleId }}',
 					},
 				},
 			},
@@ -37,7 +38,7 @@ export const detectionRuleDescription: INodeProperties[] = [
 				routing: {
 					request: {
 						method: 'GET',
-						url: '/security/rules/detectionRules',
+						url: '/rules/detectionRules',
 					},
 				},
 			},
@@ -49,7 +50,7 @@ export const detectionRuleDescription: INodeProperties[] = [
 				routing: {
 					request: {
 						method: 'POST',
-						url: '/security/rules/detectionRules',
+						url: '/rules/detectionRules',
 					},
 				},
 			},
@@ -61,14 +62,15 @@ export const detectionRuleDescription: INodeProperties[] = [
 				routing: {
 					request: {
 						method: 'DELETE',
-						url: '/security/rules/detectionRules/{{ $parameter.detectionRuleId }}',
+						url: '/rules/detectionRules/{{ $parameter.detectionRuleId }}',
 					},
 				},
 			},
 		],
 		default: 'getAll',
-		...getOneDetectionRuleDescription,
-		...createDetectionRuleDescription,
-		...deleteDetectionRuleDescription,
 	},
+	...getOneDetectionRuleDescription,
+	...createDetectionRuleDescription,
+	...deleteDetectionRuleDescription,
+	...getAllDetectionRuleDescription,
 ];

nodes/Msgraphsecurity/resources/secureScore/index.ts

@@ -1,4 +1,5 @@
 import { INodeProperties } from 'n8n-workflow';
+import { getManySecureScoreDescription } from './getMany';
 
 const showOnlyIfOperationIsSecureScore = {
 	resource: ['secureScore'],
@@ -41,4 +42,5 @@ export const secureScoreDescription: INodeProperties[] = [
 		],
 		default: 'get',
 	},
+	...getManySecureScoreDescription,
 ];