Merge pull request #31 from aferraromedina/fix-bug-with-connection-factory

fix: fix dispose of SqlConnection

Author: aferraromedina

Doppler.ReportingApi.Test/Utils/ServiceCollectionExtensions.cs

@@ -10,7 +10,7 @@ public static class ServiceCollectionExtensions
         public static void SetupConnectionFactory(this IServiceCollection services, DbConnection dbConnection)
         {
             var mockDatabaseConnectionFactory = new Mock<IDatabaseConnectionFactory>();
-            mockDatabaseConnectionFactory.Setup(a => a.GetConnection()).ReturnsAsync(dbConnection);
+            mockDatabaseConnectionFactory.Setup(a => a.GetConnection()).Returns(dbConnection);
             services.AddSingleton(mockDatabaseConnectionFactory.Object);
         }
 

Doppler.ReportingApi/Infrastructure/DatabaseConnectionFactory.cs

@@ -20,11 +20,6 @@ public DatabaseConnectionFactory(IOptions<DopplerDatabaseSettings> dopplerDataBa
         /// Open new connection and return it for use
         /// </summary>
         /// <returns></returns>
-        public async Task<IDbConnection> GetConnection()
-        {
-            var cn = new SqlConnection(_connectionString);
-            await cn.OpenAsync();
-            return cn;
-        }
+        public IDbConnection GetConnection() => new SqlConnection(_connectionString);
     }
 }

Doppler.ReportingApi/Infrastructure/IDatabaseConnectionFactory.cs

@@ -5,6 +5,6 @@ namespace Doppler.ReportingApi.Infrastructure
 {
     public interface IDatabaseConnectionFactory
     {
-        Task<IDbConnection> GetConnection();
+        IDbConnection GetConnection();
     }
 }

Doppler.ReportingApi/Infrastructure/SummaryRepository.cs

@@ -18,7 +18,7 @@ public SummaryRepository(IDatabaseConnectionFactory connectionFactory)
 
         public async Task<CampaignsSummary> GetCampaignsSummaryByUserAsync(string userName, DateTime startDate, DateTime endDate)
         {
-            using (var connection = await _connectionFactory.GetConnection())
+            using (var connection = _connectionFactory.GetConnection())
             {
                 var dummyDatabaseQuery = @"
                 SELECT
@@ -62,7 +62,7 @@ Campaign.IdScheduledTask IS NULL AND --Exclude automations
 
         public async Task<SubscribersSummary> GetSubscribersSummaryByUserAsync(string userName, DateTime startDate, DateTime endDate)
         {
-            using (var connection = await _connectionFactory.GetConnection())
+            using (var connection = _connectionFactory.GetConnection())
             {
                 var dummyDatabaseQuery = @"
                 SELECT
@@ -86,7 +86,7 @@ FROM Subscriber S
 
         public async Task<SystemUsageSummary> GetSystemUsageAsync(string accountName)
         {
-            using (var connection = await _connectionFactory.GetConnection())
+            using (var connection = _connectionFactory.GetConnection())
             {
                 var databaseQuery = @"
                 SELECT