Skip to content

Commit 723c479

Browse files
Merge pull request #109 from MarianoHerrera/DSL-1492-refactor-campaign-stats
Refactor Stats from Campaign
2 parents 6ab564c + 6bb8d5f commit 723c479

2 files changed

Lines changed: 11 additions & 13 deletions

File tree

Doppler.ReportingApi/Infrastructure/CampaignRepository.cs

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -45,18 +45,15 @@ FROM dbo.usertimezone timezone
4545
DATEADD(MINUTE, @timezone, C.[UTCSentDate])
4646
AS DATE
4747
) AS [Date]
48-
,COALESCE(C.[AmountSentSubscribers], C.[AmountSubscribersToSend], 0) AS [Sent]
49-
,ISNULL(C.[DistinctOpenedMailCount],0) [Opens]
50-
,ISNULL(C.[DistinctClickCount],0) [Clicks]
51-
,ISNULL(C.[HardBouncedMailCount],0) [Hard]
52-
,ISNULL (C.[SoftBouncedMailCount],0) [Soft]
53-
,(CASE C.[Status]
54-
WHEN 9
55-
THEN ISNULL(C.[UnsubscriptionsCount],0)
56-
ELSE 0
57-
END) [Unsubscribes]
48+
,COALESCE(CS.[AmountSentSubscribers], CS.[AmountSubscribersToSend], 0) AS [Sent]
49+
,ISNULL(CS.[DistinctOpenedMailCount],0) [Opens]
50+
,ISNULL(CS.[DistinctClickCount],0) [Clicks]
51+
,ISNULL(CS.[HardBouncedMailCount],0) [Hard]
52+
,ISNULL (CS.[SoftBouncedMailCount],0) [Soft]
53+
,ISNULL(CS.[UnsubscriptionsCount],0) [Unsubscribes]
5854
,0 [Spam]
5955
FROM [dbo].[Campaign] C WITH (NOLOCK)
56+
LEFT JOIN dbo.CampaignStats CS ON CS.IdCampaign = C.IdCampaign
6057
JOIN [dbo].[User] U WITH (NOLOCK)
6158
ON C.[IdUser] = U.[IdUser]
6259
WHERE

Doppler.ReportingApi/Infrastructure/SummaryRepository.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,14 @@ public async Task<CampaignsSummary> GetCampaignsSummaryByUserAsync(string userNa
2929
CAST(NULLIF((ISNULL(T.DistinctOpenedMailCount, 0) + ISNULL(T.UnopenedMailCount, 0)), 0) AS FLOAT) * 100 AS ClickThroughRate
3030
FROM (
3131
SELECT
32-
SUM(Campaign.AmountSentSubscribers) AS TotalSentEmails,
33-
SUM(Campaign.DistinctOpenedMailCount) AS DistinctOpenedMailCount,
32+
SUM(CS.AmountSentSubscribers) AS TotalSentEmails,
33+
SUM(CS.DistinctOpenedMailCount) AS DistinctOpenedMailCount,
3434
35-
SUM(Campaign.UnopenedMailCount) AS UnopenedMailCount,
35+
SUM(CS.UnopenedMailCount) AS UnopenedMailCount,
3636
SUM(LinkInfo.UniqueClickCount) AS UniqueClickCount
3737
FROM [user]
3838
INNER JOIN Campaign WITH (NOLOCK) on [user].iduser = Campaign.IdUser
39+
LEFT JOIN CampaignStats CS ON CS.IdCampaign = Campaign.IdCampaign
3940
OUTER APPLY (
4041
SELECT COUNT(DISTINCT LT.IdSubscriber) AS UniqueClickCount
4142
FROM Link L WITH (NOLOCK)

0 commit comments

Comments
 (0)