Skip to content

Refactor Stats from Campaign#109

Merged
MarianoHerrera merged 6 commits into
FromDoppler:mainfrom
MarianoHerrera:DSL-1492-refactor-campaign-stats
Apr 15, 2026
Merged

Refactor Stats from Campaign#109
MarianoHerrera merged 6 commits into
FromDoppler:mainfrom
MarianoHerrera:DSL-1492-refactor-campaign-stats

Conversation

@MarianoHerrera
Copy link
Copy Markdown
Contributor

@MarianoHerrera MarianoHerrera commented Jan 27, 2026

Use new table CampaignStats

Fixes: DSL-1492

Checklist:

  • I have paid attention to this PR title and description
  • I have performed a self-review of my code
  • I have built it locally (or my changes does not affect the build)
  • I have checked all tests still run ok at Doppler.ReportingApiTest project
  • I have added at least one simple unit test covering the new code

@emoralesms
Copy link
Copy Markdown
Contributor

Lo veo bien Mariano ! deberiamos aplicar el cambio también en los SP utilizados para los CSV

@emoralesms
Copy link
Copy Markdown
Contributor

Para cuando vuelvas @MarianoHerrera, en este PR se modifico todo doppler-reporting-api, ahora usa un SP propio tanto para esta app como para doppler-reports. Lleve los special reports a la ultima versión que me sugeria GIT antes de que empezaramos a modificarlos (te aviso porque vas a tener que volver a modificarlos, me imagino lo tenes en otro PR eso, para agregarle el JOIN con estas nuevas tablas de Stats). Por otro lado los nuevos SP se llaman:

  • CampaignsSent_CampaignsMetrics
  • CampaignsSent_CampaignsByMonthMetrics

A estos también hay que agregarles el nuevo JOIN, de última después lo vemos juntos o lo puedo encarar yo, como prefieras.

@MarianoHerrera MarianoHerrera force-pushed the DSL-1492-refactor-campaign-stats branch from f62f74f to 5ba5d31 Compare February 18, 2026 16:16
@pull-request-size pull-request-size Bot added size/S and removed size/M labels Feb 18, 2026
@MarianoHerrera MarianoHerrera force-pushed the DSL-1492-refactor-campaign-stats branch from e1f267f to 275848a Compare April 15, 2026 19:32
@MarianoHerrera MarianoHerrera merged commit 723c479 into FromDoppler:main Apr 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants