Skip to content

Implement support for s3 storage#175

Open
RodrigoPereyraDiaz wants to merge 4 commits into
masterfrom
implement-support-for-S3-storage
Open

Implement support for s3 storage#175
RodrigoPereyraDiaz wants to merge 4 commits into
masterfrom
implement-support-for-S3-storage

Conversation

@RodrigoPereyraDiaz

@RodrigoPereyraDiaz RodrigoPereyraDiaz commented Nov 15, 2021

Copy link
Copy Markdown
Contributor
  • refactor to improve test and increment coverage

@codecov

codecov Bot commented Nov 15, 2021

Copy link
Copy Markdown

Codecov Report

Merging #175 (88e36c6) into master (cc3872a) will decrease coverage by 0.73%.
The diff coverage is 47.61%.

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   57.84%   57.10%   -0.74%     
==========================================
  Files          38       39       +1     
  Lines         389      408      +19     
==========================================
+ Hits          225      233       +8     
- Misses        164      175      +11     
Impacted Files Coverage Δ
MailerQ/MessageStore/S3MessageStorage.cs 26.66% <26.66%> (ø)
MailerQ/MessageStore/MessageStorage.cs 100.00% <100.00%> (ø)
MailerQ/MessageStore/MongoDBMessageStorage.cs 54.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3872a...88e36c6. Read the comment docs.

@RodrigoPereyraDiaz
RodrigoPereyraDiaz force-pushed the implement-support-for-S3-storage branch 2 times, most recently from 5f3f12c to 4adc60a Compare November 15, 2021 14:47
@RodrigoPereyraDiaz
RodrigoPereyraDiaz force-pushed the implement-support-for-S3-storage branch 2 times, most recently from b1eeaec to 3801c39 Compare May 23, 2022 12:30
@RodrigoPereyraDiaz
RodrigoPereyraDiaz force-pushed the implement-support-for-S3-storage branch from 3801c39 to 88e36c6 Compare July 7, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant