Skip to content

Changed from deprecated PropTypes to prop-types package to support React 16.0.0#96

Open
mckn wants to merge 3 commits into
FuYaoDe:masterfrom
mckn:master
Open

Changed from deprecated PropTypes to prop-types package to support React 16.0.0#96
mckn wants to merge 3 commits into
FuYaoDe:masterfrom
mckn:master

Conversation

@mckn

@mckn mckn commented Sep 29, 2017

Copy link
Copy Markdown

Hello,

I changed so this package have a dependency on the "prop-types" package instead of getting the PropTypes from React. It is deprecated since a while back and PropTypes is removed in the full version for React 16.

Please accept this PR. Thanks!

@ghost

ghost commented Oct 5, 2017

Copy link
Copy Markdown

@mckn would you mind including in that PR a revert back to the original react-native-swiper instead of @FuYaoDe which is not being maintained and affected by the same PropTypes issue with React 16?

@mlabrum

mlabrum commented Oct 10, 2017

Copy link
Copy Markdown

@FuYaoDe could we get this merged?

@ghost

ghost commented Oct 17, 2017

Copy link
Copy Markdown

@mckn I still get an error using this patch, related to react-native-swiper, not you?

@ScreamZ

ScreamZ commented Oct 21, 2017

Copy link
Copy Markdown

Need this being merged... Thanks

@kodamirmo

Copy link
Copy Markdown

Any update? merge asap please

@flybayer

Copy link
Copy Markdown

I need this too.

@ofirdagan

Copy link
Copy Markdown

👍 - but this PR is not enough.. the react-native-swiper also needs to be upgraded. This fork doesn't work w/ the original react-native-swiper`

@ghost

ghost commented Jan 25, 2018

Copy link
Copy Markdown

@ofirdagan I've sent an email to @FuYaoDe here to try to unlock the situation.

@vuyani-k

Copy link
Copy Markdown

MERGE PLZ

@manishoo

Copy link
Copy Markdown

MERGE PLEASE!

@ghost

ghost commented Apr 16, 2018

Copy link
Copy Markdown

@jolinkomo-code @mehdijjz I haven't heard back from @FuYaoDe in my previous contact attempt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants