Skip to content

Commit c972e1f

Browse files
committed
Merge branch 'lab/credit' into 'export/v1-2-2'
Add security researcher credit for CWE-502 finding See merge request onecomp/onecomp-lab!105
2 parents 352063a + 2b09f6c commit c972e1f

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
- **Breaking change**: existing callers of `load_quantized_model_pt()` must pass `allow_unsafe_deserialization=True` for trusted `.pt` files.
1515
- **`Quantizer.load_results()` / `ResultLoader`**: same hardening applied. Loading with `weights_only=False` now requires `allow_unsafe_deserialization=True` (added as a `ResultLoader` field), and logs a warning. The safe `weights_only=True` path is unchanged.
1616
- Updated docstrings, docs, and the LoRA SFT example to document the risk and the required opt-in.
17+
- **Credit**: this unsafe deserialization issue (CWE-502) was responsibly disclosed by **Nir Yehoshua, Cipher Security Labs**. Thank you for the report.
1718

1819
## [v1.2.0] 2026-06-08
1920

SECURITY.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,3 +37,9 @@ To help us triage and resolve the issue quickly, please include as much of the f
3737
Please make a good-faith effort to avoid privacy violations, data destruction, and service interruption while investigating. We ask that you give us a reasonable amount of time to address the issue before any public disclosure.
3838

3939
Thank you for helping keep OneComp and its users safe.
40+
41+
## Security Acknowledgments
42+
43+
We thank the following researchers for responsibly disclosing security issues in OneComp:
44+
45+
- **Nir Yehoshua, Cipher Security Labs** — unsafe deserialization in `QuantizedModelLoader.load_quantized_model_pt()` (CWE-502), fixed in v1.2.1.

0 commit comments

Comments
 (0)