fix(Outreach): delete stale scraper_results.csv before each run#260
Open
octo-patch wants to merge 1 commit into
Open
fix(Outreach): delete stale scraper_results.csv before each run#260octo-patch wants to merge 1 commit into
octo-patch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #256
Problem
Outreach.start()runs the scraper and then checksos.path.exists(output_path)to determine if scraping succeeded. However,.mp/scraper_results.csvalways points to a fixed path (get_results_cache_path()). If the file already exists from a previous successful run, this check passes even when the current scraper invocation fails or times out — causing the outreach flow to send emails based on stale lead data.Solution
Delete
scraper_results.csvbefore invoking the scraper. After the scraper finishes, the existingos.path.exists()check is now reliable: the file can only exist if the current run produced it.Testing
.mp/scraper_results.csvis created.os.path.exists()returnsFalseand the error path is taken correctly.