fix(outreach): discard stale scraper results#264
Open
Gujiassh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.mp/scraper_results.csvoutput before each Outreach scraper run.os.path.exists(output_path)guard, so a failed or timed-out scraper run no longer falls through to stale results from an earlier run.Fixes #256.
Validation
python3 -m unittest tests.test_outreach_scraper_results -vpython3 -m unittest tests.test_post_bridge_client tests.test_outreach_scraper_results -vpython3 -m py_compile src/classes/Outreach.py tests/test_outreach_scraper_results.pygit diff --checkNote: full
python3 -m unittest discover -s tests -vis blocked in this clean worktree by missing optional/runtime dependencies (srt_equalizer,termcolor) used by existing tests/modules. The focused Outreach regression and existing PostBridge client tests above pass with local dependency fakes where needed.