Skip to content

Commit 6f54b6a

Browse files
committed
update documentation for EvaluateModel
1 parent 01d050f commit 6f54b6a

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

selene_sdk/evaluate_model.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,11 +147,13 @@ def __init__(self,
147147

148148
self._test_data, self._all_test_targets = \
149149
self.sampler.get_data_and_targets(self.batch_size, n_test_samples)
150-
# TODO: we should be able to do this on the sampler end, vs here...
151-
# this is a bad workaround, since self._test_data still has the full
152-
# featureset in it, and we select the subset during `evaluate`
150+
# TODO: we should be able to do this on the sampler end instead of
151+
# here. the current workaround is problematic, since
152+
# self._test_data still has the full featureset in it, and we
153+
# select the subset during `evaluate`
153154
self._all_test_targets = self._all_test_targets[:, self._use_ixs]
154155

156+
# reset Genome base ordering when applicable.
155157
if (hasattr(self.sampler, "reference_sequence") and
156158
isinstance(self.sampler.reference_sequence, Genome)):
157159
if _is_lua_trained_model(model):
@@ -160,6 +162,11 @@ def __init__(self,
160162
Genome.update_bases_order(['A', 'C', 'G', 'T'])
161163

162164
def _write_features_ordered_to_file(self):
165+
"""
166+
Write the feature ordering specified by `use_features_ord`
167+
after matching it with the `features` list from the class
168+
initialization parameters.
169+
"""
163170
fp = os.path.join(self.output_dir, 'use_features_ord.txt')
164171
with open(fp, 'w+') as file_handle:
165172
for f in self.features:

0 commit comments

Comments
 (0)