[ENHANCEMENT] Allow ESCAPE key to exit editors when first opened#7510
Closed
T5mpler wants to merge 222 commits into
Closed
[ENHANCEMENT] Allow ESCAPE key to exit editors when first opened#7510T5mpler wants to merge 222 commits into
T5mpler wants to merge 222 commits into
Conversation
…bject writer. Co-Authored-By: TechnikTil <TechnikTil@users.noreply.github.com>
approved by Kade and Eric via Discord
* Opening FNFC files * rrr -> rr in get_currentSongMetadata() --------- Co-Authored-By: Cameron Taylor <cameron.taylor.ninja@gmail.com>
…ted easier by other haxeUI stuff
Working properties panel with placeholder events hooked up. TODO: Add PurSnake's easing graphs. Bind up the inputs for the zoom camera field Fix panel title not updating properly. Redo menu items to use @:bind, add the CameraEditorCommandHandler Cleanup properties panel event bindings, and implement ease preview (mostly) Merge remote-tracking branch 'secret/master' into feature/eog-properties-panel-electric-boogaloo Fix some merge conflict resolution.
github-actions
Bot
added
status: pending triage
NotHyper-474
added
type: enhancement
Hundrec
changed the title
Hundrec
force-pushed
the
preview/camera-editor
branch
3 times, most recently
from
May 6, 2026 07:22
4a48622 to
ba98ece
Compare
Hundrec
force-pushed
the
preview/camera-editor
branch
3 times, most recently
from
May 15, 2026 07:31
2f16387 to
f0bf30b
Compare
Contributor
|
This should be closed due to the Camera Editor not accepting enhancements at the moment. |
NotHyper-474
added
status: needs revision
Member
|
We've added loading from song templates now, so this won't be a concern. |
Hundrec
added
status: rejected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the user to use the ESCAPE key for if they want to exit any editors firsthand when opening them.
While the F4 key does exist to automatically return to the Main Menu, a lot of people generally don't know first hand that this keybind exists, leading you to believe that you're unable to exit the editor at all when opening it. This is especially bad for the Camera Editor as the user could believe they're softlocked if they don't have any .fnfc files to continue on, and DON'T know about the F4 key.