chore: Add null-safety to IntervalShake#7527
Open
VICK-sys wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
size: huge
NotHyper-474
added
size: medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Part of #4303
Description
Adds
@:nullSafety(Loose mode) tofunkin.effects.IntervalShakeand resolves the resulting compile errors.Behavior change worth flagging: previously, if
objectwas null at the time ofstop()orshakeProgress()running (e.g., ifdestroy()was called from a callbackmid-shake), the code would null-crash. With these guards, position updates are silently skipped instead. The original behavior was a latent bug; this is strictly safer.
Screenshots/Videos
Smoke-tested in-game with no visual regression. Capsule shake during rank slam works identically to
develop:https://github.com/user-attachments/assets/631be32e-897f-4813-a5d2-c239d4219b89