[BUGFIX] Unfocus Chart Editor dropdown after selecting item#7528
Open
VICK-sys wants to merge 2 commits into
Open
[BUGFIX] Unfocus Chart Editor dropdown after selecting item#7528VICK-sys wants to merge 2 commits into
VICK-sys wants to merge 2 commits into
Conversation
Hundrec
requested changes
May 9, 2026
Member
Hundrec
left a comment
There was a problem hiding this comment.
This bug has bothered me forever!
The PR's behavior is a big improvement, as it allows left clicks to unfocus the dropdown.
However, right clicking and scrolling is still gated until you left click.
The PR would be perfect if you fixed this too!
Author
I'm on it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes #2956
Description
Fixes the chart editor input lockout that occurred when a HaxeUI toolbox field had focus (blue outline). After interacting with a field, playtesting with the toolbox open,
and reopening the toolbox, the field's focus was auto-restored, and
isHaxeUIFocusedreturning true gated all chart editor input (scroll, note placement, playtest hotkey,etc.).
The fix: in
ChartEditorToolboxHandler.showToolboxand.hideToolbox, directly callIFocusable.focus = falseon the currently-focused element viaFocusManager.instance.focus. This bypasses HaxeUI'sset_focus(null)API, which has an asymmetric implementation:get_focuswalks all root components, butset_focus(null)only clears_lastFocusesforScreen.instance.topComponent, so focus living on a non-top root (like a dialog) can't be cleared through it.Screenshots/Videos
Demo.Video.mp4