Skip to content

[BUGFIX] Fix switch editor button getting stuck highlighted#7536

Open
VICK-sys wants to merge 241 commits into
FunkinCrew:preview/camera-editorfrom
VICK-sys:fix/camera-editor-button-stuck-highlight
Open

[BUGFIX] Fix switch editor button getting stuck highlighted#7536
VICK-sys wants to merge 241 commits into
FunkinCrew:preview/camera-editorfrom
VICK-sys:fix/camera-editor-button-stuck-highlight

Conversation

@VICK-sys
Copy link
Copy Markdown

@VICK-sys VICK-sys commented May 7, 2026 •
edited
Loading

Linked Issues

Fixes #7493

Description

Clicking "Go to Camera Editor" (in Chart Editor) or "Go to Chart Editor" (in Camera Editor) left a blue focus outline on the destination editor's matching menubar item until the user moused over something else. The clicked menu item retained focus across FlxG.switchState because HaxeUI's focus reference lives on Screen.instance (a singleton) and persists.

Same archetype as #7528 — directly clear the focused IFocusable via FocusManager.instance.focus before FlxG.switchState, in both ChartEditorState.moveToCameraEditor and CameraEditorState.tryMoveToChartEditor.

Screenshots/Videos

Demo.Video.mp4

@github-actions github-actions Bot added pr: haxe PR modifies game code. pr: documentation PR modifies documentation or README files. status: pending triage Awaiting review. labels May 7, 2026
@VICK-sys VICK-sys changed the base branch from develop to preview/camera-editor May 7, 2026 21:49
@github-actions github-actions Bot added the size: huge A huge pull request with more than 500 changes. label May 7, 2026
@NotHyper-474 NotHyper-474 added type: minor bug Involves a minor bug or issue. topic: chart editor Related to the operation of the Chart Editor. size: medium A medium pull request with 100 or fewer changes. topic: camera editor Related to the operation of the Camera Editor. and removed size: huge A huge pull request with more than 500 changes. pr: documentation PR modifies documentation or README files. labels May 7, 2026
@Hundrec Hundrec changed the title Fix/camera editor button stuck highlight [BUGFIX] Fix switch editor button getting stuck highlighted May 9, 2026
@Hundrec Hundrec self-requested a review May 9, 2026 06:35
Hundrec
Hundrec requested changes May 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to #7528, this PR only unhighlights the button if you hover over it again.
Can you make it unhighlight automatically?

Image

@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels May 9, 2026
@VICK-sys
Copy link
Copy Markdown
Author

VICK-sys commented May 9, 2026

Similar to #7528, this PR only unhighlights the button if you hover over it again. Can you make it unhighlight automatically?

Image

I'm on it

@Hundrec Hundrec added status: pending triage Awaiting review. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels May 9, 2026
EliteMasterEric and others added 11 commits May 9, 2026 04:44
@EliteMasterEric @TechnikTil @Hundrec
Update json2object to include a stable and better-formatted Dynamic o…
aec9b4f 
…bject writer.

Co-Authored-By: TechnikTil <TechnikTil@users.noreply.github.com>
@EliteMasterEric @Hundrec
Launch the game with -DEYESOFGOD to open the camera editor
e09bcf2
@ninjamuffin99 @Hundrec
cleanup and use @:bind for ui functions
49ada36 
approved by Kade and Eric via Discord
@Kade-github @ninjamuffin99 @Hundrec
Opening FNFC files in CameraEditorState (FunkinCrew#2150)
2c0e102 
* Opening FNFC files

* rrr -> rr in get_currentSongMetadata()

---------

Co-Authored-By: Cameron Taylor <cameron.taylor.ninja@gmail.com>
@MAJigsaw77 @Hundrec
Fix compiling when FEATURE_CAMERA_EDITOR is disabled.
43a2cd1
@Kade-github @Hundrec
Stage Preview Loading
58bd935
@EliteMasterEric @Hundrec
Add songChartData.editorData fields.
2f770f3
@ninjamuffin99 @Hundrec
remove unneeded variable setup in CameraEditorState
5f227aa
@ninjamuffin99 @Hundrec
small cleanup to character building in CameraEditorState
5823258
@Kade-github @Hundrec
Audio playback in CameraEditor
5b58d67
@ninjamuffin99 @Hundrec
some small tidying to the audio playback in camera editor
581a9f7
EliteMasterEric and others added 18 commits May 9, 2026 04:45
@EliteMasterEric @Hundrec
Properly track old and new times during event resize, so left-resize …
950b687 
…properly restores the original position
@EliteMasterEric @Hundrec
Fix camera editor Save As saved state
2625061
@EliteMasterEric @Hundrec
Fix camera editor variation after chart load
8415ea6
@Hundrec
Set difficulty after variation in Camera Editor
f66cb64 
The variation was being resolved, but the difficulty wasn't. This ended up loading a chart without the current variation with no note data.

The new function is a bandaid fix, it should be made more versatile in the future.
@EliteMasterEric @Hundrec
Fix loadFromPath not respecting targetSongVariation on the Camera Edi…
1373d92 
…tor and Chart Editor
@EliteMasterEric @Hundrec
Fix an issue where targetSongPosition would get immediately reset a…
ffff7e3 
…fter loading a song.
@EliteMasterEric @Hundrec
Fix an issue where loadFromTemplate would ignore the `targetSongPos…
fafd9b7 
…ition` parameter
@Hundrec
Load variation before difficulty in Chart Editor
f950cc3 
This fixes entering the Chart Editor from Freeplay/PlayState not setting the right difficulty.
@Hundrec
Set Chart Editor song position from Camera Editor
a763dcf
@ninjamuffin99 @Hundrec
fix macos gestures in the CameraViewport in camera editor
0679f89
@Hundrec
Camera Editor Preview 2
7346e59
@EliteMasterEric @Hundrec
Improved code comments and code style standardization for the Camera …
e8d4ac5 
…Editor.
@EliteMasterEric @Hundrec
Add camera editor paste notifications
756f6f2
@EliteMasterEric @Hundrec
Fixed pasting on the wrong layer, and always center the copy notifica…
9d5d651 
…tion so it doesn't go offscreen.
@EliteMasterEric @Hundrec
Use HaxeUI for the copy notification.
9c5f9a7
@KarimAkra @Hundrec
Added Fit Camera to Viewport to camera editor's view options
1636a4c
@PurSnake @Hundrec
fix for amd and optimization
032e8db
@Hundrec
Disable song script event dispatching for now
ca56364 
This reverts commits ed15ce0d1a964036d1ad99f0e97771a3bf3cde3d and 67bfa080f96866774a7e864778c846bdcf97d476.
@Hundrec Hundrec force-pushed the preview/camera-editor branch from ba98ece to ca56364 Compare May 9, 2026 10:46
@NotHyper-474
Copy link
Copy Markdown
Collaborator

NotHyper-474 commented May 9, 2026 •
edited
Loading

Base branch got force-pushed; needs a rebase

@NotHyper-474 NotHyper-474 added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels May 9, 2026
@VICK-sys VICK-sys force-pushed the fix/camera-editor-button-stuck-highlight branch from 1bb5c33 to 2ef6698 Compare May 9, 2026 17:28
@NotHyper-474 NotHyper-474 added status: pending triage Awaiting review. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels May 9, 2026
@NotHyper-474 NotHyper-474 requested a review from Hundrec May 9, 2026 17:30
@Hundrec Hundrec force-pushed the preview/camera-editor branch 2 times, most recently from 2f16387 to f0bf30b Compare May 15, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hundrec Hundrec Awaiting requested review from Hundrec

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. topic: camera editor Related to the operation of the Camera Editor. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.