[BUGFIX] Hide Chart Editor toolboxes from every playtest entry point#7539
Open
VICK-sys wants to merge 1 commit into
Open
[BUGFIX] Hide Chart Editor toolboxes from every playtest entry point#7539VICK-sys wants to merge 1 commit into
VICK-sys wants to merge 1 commit into
Conversation
github-actions
Bot
added
status: pending triage
NotHyper-474
added
type: minor bug
Hundrec
changed the title
Hundrec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closes #6851
Description
Chart editor toolbox dialogs (Window → Events, Playtest Properties, etc.) stayed open during playtest when launched from the menubar (Test → Playtest Full) or from gamepad START. Reopening the same toolbox after returning to the chart editor crashed.
Only the Enter-keybind playtest path called
hideAllToolboxes()before launching the substate, so other entry points left toolbox HaxeUI components in an inconsistent state across the substate cycle.The fix moves the call into
testSongInPlayStateitself so every entry point — menubar, gamepad START, Enter, and retest-from-PlayState — hides toolboxes before the playtest substate starts. The now-redundant calls inhandleTestKeybindsandChartEditorGamepadHandlerare removed.Screenshots/Videos
Demo.Video.mp4