[BUGFIX] Close Chart Editor menubar dropdowns before playtest#7540
Open
VICK-sys wants to merge 1 commit into
Open
[BUGFIX] Close Chart Editor menubar dropdowns before playtest#7540VICK-sys wants to merge 1 commit into
VICK-sys wants to merge 1 commit into
Conversation
github-actions
Bot
added
pr: haxe
NotHyper-474
added
type: minor bug
4 tasks
Hundrec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closes #7533
Description
Top-bar dropdown menus (File, Edit, View, etc.) stayed open after pressing Enter to playtest from the chart editor. The dropdown panel was hidden during playtest, but it reappeared on return — and the menubar's internal selected-button state was stale, so clicking the same dropdown afterwards behaved incorrectly.
Dropdowns are added to
Screen.instance(not the chart editor's own UI tree), so they survive the substate transition. The fix calls the menubar's internalhideCurrentMenufromtestSongInPlayState, which both hides the panel and clears_currentMenu/_currentButton.selected— so every entry point (Enter, gamepad START, menubar Test → Playtest) leaves the menubar in a clean state.Screenshots/Videos
Demo.Video.mp4