[BUGFIX] Use stage directory for asset library in Camera Editor#7545
Open
VICK-sys wants to merge 240 commits into
Open
[BUGFIX] Use stage directory for asset library in Camera Editor#7545VICK-sys wants to merge 240 commits into
VICK-sys wants to merge 240 commits into
Conversation
github-actions
Bot
added
size: huge
VICK-sys
changed the title
NotHyper-474
added
type: minor bug
Contributor
|
Was gonna say why no Haxe? |
4 tasks
Hundrec
changed the title
…bject writer. Co-Authored-By: TechnikTil <TechnikTil@users.noreply.github.com>
approved by Kade and Eric via Discord
* Opening FNFC files * rrr -> rr in get_currentSongMetadata() --------- Co-Authored-By: Cameron Taylor <cameron.taylor.ninja@gmail.com>
…ooming to left edge
…oom properties panel code
…properly restores the original position
The variation was being resolved, but the difficulty wasn't. This ended up loading a chart without the current variation with no note data. The new function is a bandaid fix, it should be made more versatile in the future.
…tor and Chart Editor
…fter loading a song.
…ition` parameter
This fixes entering the Chart Editor from Freeplay/PlayState not setting the right difficulty.
…tion so it doesn't go offscreen.
This reverts commits ed15ce0d1a964036d1ad99f0e97771a3bf3cde3d and 67bfa080f96866774a7e864778c846bdcf97d476.
Hundrec
force-pushed
the
preview/camera-editor
branch
from
ba98ece to
ca56364
Compare
VICK-sys
force-pushed
the
fix/camera-editor-schoolerect-asset-library
branch
from
66d4060 to
dc52a82
Compare
Hundrec
force-pushed
the
preview/camera-editor
branch
2 times, most recently
from
2f16387 to
f0bf30b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes #7480
Description
CameraEditorState.buildStage was setting the asset library via Stage.getCampaignID(stageID), whose switch is missing the schoolErect case. It fell through to default: stageName, so Paths.setCurrentLevel('schoolerect') made weeb/erect/masks/* (in the week6 library) unresolvable and DropShadowShader.loadAltMask returned null.
Switched to currentStage._data?.directory ?? "shared", matching LoadingState.loadPlayState's pattern.
Screenshots/Videos
Demo.Video.mp4