[BUGFIX] Hide OFFICIAL OST label on Freeplay random capsule#7548
Open
VICK-sys wants to merge 1 commit into
Open
[BUGFIX] Hide OFFICIAL OST label on Freeplay random capsule#7548VICK-sys wants to merge 1 commit into
VICK-sys wants to merge 1 commit into
Conversation
github-actions
Bot
added
size: tiny
NotHyper-474
added
type: minor bug
4 tasks
Hundrec
changed the title
Contributor
|
1 line banger 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes #7338
Description
AlbumRoll.getOSTNameOverride() returned Constants.DEFAULT_OST_NAME for any albumId == null, so the random capsule's OST label stayed at "OFFICIAL OST" even though its album image and title were hidden. Per @NotHyper-474's #7338 (comment), the null branch should fall through to return null; FreeplayState.updateOSTName already coalesces a null return to an empty string.
The class is @:nullSafety, so a straight removal of albumId == null || doesn't compile (contains rejects Null). Inverted the predicate to albumId != null && … for the same end-effect.
Screenshots/Videos
Demo.Video.mp4