[BUGFIX] Fix Camera Editor event data pasting into layer name#7549
Open
VICK-sys wants to merge 240 commits into
Open
[BUGFIX] Fix Camera Editor event data pasting into layer name#7549VICK-sys wants to merge 240 commits into
VICK-sys wants to merge 240 commits into
Conversation
github-actions
Bot
added
the
size: huge
github-actions
Bot
added
pr: haxe
NotHyper-474
added
type: minor bug
Contributor
|
Bro holy moly chill out on the PRs dude /j. |
Hundrec
changed the title
…bject writer. Co-Authored-By: TechnikTil <TechnikTil@users.noreply.github.com>
approved by Kade and Eric via Discord
* Opening FNFC files * rrr -> rr in get_currentSongMetadata() --------- Co-Authored-By: Cameron Taylor <cameron.taylor.ninja@gmail.com>
…ooming to left edge
…oom properties panel code
…properly restores the original position
The variation was being resolved, but the difficulty wasn't. This ended up loading a chart without the current variation with no note data. The new function is a bandaid fix, it should be made more versatile in the future.
…tor and Chart Editor
…fter loading a song.
…ition` parameter
This fixes entering the Chart Editor from Freeplay/PlayState not setting the right difficulty.
…tion so it doesn't go offscreen.
This reverts commits ed15ce0d1a964036d1ad99f0e97771a3bf3cde3d and 67bfa080f96866774a7e864778c846bdcf97d476.
Hundrec
force-pushed
the
preview/camera-editor
branch
from
ba98ece to
ca56364
Compare
VICK-sys
force-pushed
the
fix/camera-editor-block-event-paste-into-layer-name
branch
from
3f26099 to
ad4bf8b
Compare
Hundrec
force-pushed
the
preview/camera-editor
branch
2 times, most recently
from
2f16387 to
f0bf30b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes #7440
Description
Camera Editor copies the event JSON to the OS clipboard. Pasting it into a layer name field dumped the JSON into the name. HaxeUI's native TextField paste happens before any Haxe-level handler can pre-empt it, so cancel/revert approaches lose the race on spam Ctrl+V. When entering edit mode, stash the OS clipboard locally and clear it (only if it looks like song JSON). Restore on exit if it's still empty, so any new copy during edit is preserved. Also gate the screen-level PasteEventsCommand on !timeline.layerPanel.isEditing.
Screenshots/Videos
Demo.Video.mp4