[BUGFIX] Fix character icons sometimes not appearing in Stage Editor#7550
Open
VICK-sys wants to merge 1 commit into
Open
[BUGFIX] Fix character icons sometimes not appearing in Stage Editor#7550VICK-sys wants to merge 1 commit into
VICK-sys wants to merge 1 commit into
Conversation
github-actions
Bot
added
size: tiny
NotHyper-474
added
type: minor bug
Contributor
|
Dude you're on a roll! |
Open
4 tasks
Hundrec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes #7500
Description
CharacterDataParser.getCharPixelIconAsset built a fresh FlxGraphic via FlxGraphic.fromFrame but only held it through a local FlxImageFrame. After the function returned, useCount dropped to 0 and Flixel destroyed the graphic on its next sweep — the returned FlxFrame.parent was now invalid:
[WARNING] Invalid call to getFramesCollections on a destroyed graphic
[ERROR] Cannot render a destroyed graphic, the placeholder image will be used instead.
The Stage Editor's Character Properties button (and picker grid) were the visible victim — they showed the FlxSprite default placeholder. Set destroyOnNoUse = false on the constructed graphic so it survives past the function scope.
Screenshots/Videos
Demo.mp4