[BUGFIX] Stop game over sounds on retry and exit#7552
Open
VICK-sys wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
size: medium
4 tasks
Hundrec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes #6788
Description
GameOverSubState.playBlueBalledSFXplayed the SFX viaFunkinSound.playOnce(...)and dropped the returned reference. With nothing tracking it, nothing could stop it when the substate closed — the remaining tail kept playing through the song restart.Screenshots/Videos
Demo.mp4