[CRASHFIX] Fix Chart Editor crashes on note search type switches and event dropdown lookups#7587
Closed
kiryvajiravuth wants to merge 3 commits into
Closed
[CRASHFIX] Fix Chart Editor crashes on note search type switches and event dropdown lookups#7587kiryvajiravuth wants to merge 3 commits into
kiryvajiravuth wants to merge 3 commits into
Conversation
…ent dropdown lookups
github-actions
Bot
added
status: pending triage
NotHyper-474
added
type: major bug
kiryvajiravuth
changed the title
NotHyper-474
added
status: rejected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
closes #7143
Description
this PR resolves the critical crashes in the Chart Editor when alternating note-type selections after a search, as well as placing certain events on an existing event causes a crash.
Changes made:
-fixes the alternating note-type crash
-fixes the event-placing crash
-added a new .hx where if you place a new event on an existing event , the existed event will be replaced by the selected event
Screenshots/Videos
Before :
Bug 1:
before-funkin-bug.mp4
Bug 2 :
also-before-funkin-bug.mp4
After :
after-funkin-bug.mp4