[BUGFIX] Fix the song restarting instead of ending#7591
Open
VirtuGuy wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
pr: haxe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes #5449
Description
This PR (hopefully) fixes the bug where the song resets instead of ending. I'm saying hopefully because this bug is weird and also because I tested this using time travel, which probably isn't the best way to test. However, time traveling right to the end of the song is 100% guaranteed to reproduce this bug as if you reproduced it accidentally, which this PR fixes that problem.
Testing is appreciated.