[BUGFIX] Fix hold note covers not appearing for overlapping sustain trails#7593
Open
VirtuGuy wants to merge 1 commit into
Open
[BUGFIX] Fix hold note covers not appearing for overlapping sustain trails#7593VirtuGuy wants to merge 1 commit into
VirtuGuy wants to merge 1 commit into
Conversation
github-actions
Bot
added
status: pending triage
Contributor
Author
|
github-actions i hope people spell it wrong |
NotHyper-474
added
type: minor bug
Collaborator
|
gtihub-acons |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
None I don't think
Description
This PR fixes an issue where overlapping sustain trails cause there to missing hold covers. This is because the hold cover pool is full and the game picks a random hold cover to use. This is resolved by removing the limit for hold note covers, which shouldn't be a huge deal anyways.
Screenshots/Videos
Before:
hold.cover.before.mp4
After:
hold.cover.after.mp4