Enable protontricks python package on Steam Deck by downloading winetricks before#929
Open
gmvi wants to merge 3 commits into
Open
Enable protontricks python package on Steam Deck by downloading winetricks before#929gmvi wants to merge 3 commits into
gmvi wants to merge 3 commits into
Conversation
Author
|
I feel silly for assuming this project was using the latest version of protontricks instead of checking 🤦. I was comparing 1.13.1 against 1.14.0, not uv-install vs pip-install. So, protontricks doesn't come with its own winetricks, and of course it doesn't see the winetricks bundled with flatpak protontricks. So on steam deck we just need to set $WINETRICKS. I also changed the download code to only download winetricks if needed. Tested up to MO2 on oblivion and up to post-MO2 game launch on morrowind, both via steam on steam deck. I can't get oblivion to run at all right now, I'll have to figure that out. @Furglitch should I squash these commits into a single one that follows the project format now or just squash-merge after review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my system python protontricks can't find winetricks automatically when installed by uv. Providing it via $WINETRICKS solves the problem without really groking what's going on. So it feels like hotfix quality right now, maybe let's not rush to merge this.
For a temporary workaround the current rewrite branch can be enabled on Steam Deck by downloading a copy of winetricks and pointing $WINETRICKS to it. Once there's a winetricks in ~/.cache/mo2-lint/downloads/, you can point $WINETRICKS to that instead.
Code has been tested against Morrowind and Oblivion via Steam on Steam Deck only.