Skip to content

fix: remove codex/lgtm gate, merge on human approve only#13

Merged
FuugaMo merged 1 commit into
masterfrom
fix/remove-codex-lgtm-gate
Mar 12, 2026
Merged

fix: remove codex/lgtm gate, merge on human approve only#13
FuugaMo merged 1 commit into
masterfrom
fix/remove-codex-lgtm-gate

Conversation

@FuugaMo
Copy link
Copy Markdown
Owner

@FuugaMo FuugaMo commented Mar 12, 2026

Simplify auto-merge: only require human Approve. Codex review is still triggered automatically as a reference, but no longer blocks the merge pipeline.

@FuugaMo FuugaMo enabled auto-merge (squash) March 12, 2026 07:57
@FuugaMo FuugaMo disabled auto-merge March 12, 2026 07:58
@FuugaMo FuugaMo merged commit ce7624e into master Mar 12, 2026
3 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c8be9f9a8a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 43 to +44
const humanApproved = [...latest.entries()].some(
([user, state]) => user !== CODEX_USER && state === 'APPROVED'
([, state]) => state === 'APPROVED'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Require non-automated approval before auto-merge

This predicate now treats any latest APPROVED review as "human approval", so an automated reviewer can satisfy the gate and merge an auto-fix PR with no human reviewer involved. In this repo, .github/workflows/codex-gate.yml explicitly handles automated Codex pull_request_review events, so this path is realistic: once that bot submits APPROVED, this workflow will merge immediately. Please restore an explicit reviewer-identity filter (or bot check) so only real human approvals count.

Useful? React with 👍 / 👎.

@NogaUwU NogaUwU deleted the fix/remove-codex-lgtm-gate branch March 15, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant