fix: update Claude selectors for issue #37#43
Conversation
|
@codex Please review this PR. If you find no critical issues, reply with "LGTM". If you find critical issues, describe them clearly. |
1 similar comment
|
@codex Please review this PR. If you find no critical issues, reply with "LGTM". If you find critical issues, describe them clearly. |
Automated ReviewAutomated reviewer found issues that need human attention before merge. Checklist
Findings
Verdict: |
1 similar comment
Automated ReviewAutomated reviewer found issues that need human attention before merge. Checklist
Findings
Verdict: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff7d0db97c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "[class*='HumanTurn']" | ||
| "[class*='HumanTurn']", | ||
| ".font-user-message", | ||
| "[class*=\"user-message\"]" |
There was a problem hiding this comment.
The selectors added here are not used by the actual turn parser, so this change does not fix Claude extraction in production. content.js still hardcodes Claude user/branch selectors in getClaudeUserTurns/navigation logic, and selectorConfig from selectors.json is only referenced by diagnostic probe paths. In the regression scenario this commit targets (new Claude DOM classes), user turns can still be missed and the extension falls back to generic alternating-role parsing, producing incorrect conversation trees.
Useful? React with 👍 / 👎.
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
This PR fixes Claude selectors to address potential regressions reported in #37. Added new generic classes for humanTurn.