fix: update chatgpt turns selectors for v0.3.7#53
Conversation
|
@codex Please review this PR. If you find no critical issues, reply with "LGTM". If you find critical issues, describe them clearly. |
1 similar comment
|
@codex Please review this PR. If you find no critical issues, reply with "LGTM". If you find critical issues, describe them clearly. |
Automated ReviewAutomated reviewer found issues that need human attention before merge. Checklist
Findings
Verdict: |
1 similar comment
Automated ReviewAutomated reviewer found issues that need human attention before merge. Checklist
Findings
Verdict: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: efbb1c98d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "div[class*=\"agent-turn\"]", | ||
| "[data-testid*=\"conversation-turn\"]", | ||
| ".group\\/conversation-turn" |
There was a problem hiding this comment.
These new ChatGPT selectors are only added to selectors.json, but the actual ChatGPT parser still uses hard-coded selectors in content.js: it first queries article[data-testid^="conversation-turn-"], then falls back only to [data-testid='conversation-turn'], [data-message-author-role], and main article (content.js lines 560-574). Since selectorConfig.platforms.chatgpt.turns is only used by diagnostics/probing, pages that now expose turns only via .group\/conversation-turn, agent-turn, or the broader data-testid* selector will still produce no turns, so this patch does not fix the reported runtime breakage.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: efbb1c98d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "div[class*=\"agent-turn\"]", | ||
| "[data-testid*=\"conversation-turn\"]", | ||
| ".group\\/conversation-turn" |
There was a problem hiding this comment.
On ChatGPT pages where v0.3.7 only exposes the new agent-turn/group/conversation-turn containers, these additions do not change runtime parsing: readChatGPTTurns() in content.js still queries only article[data-testid^="conversation-turn-"] and the fallback list [data-testid='conversation-turn'], [data-message-author-role], and main article, while selectorConfig is only used by the selector probe/diagnostics. As a result the reported no_turns_detected failure remains even though the probe may show the new selectors matching.
Useful? React with 👍 / 👎.
2 participants
Automated fix for issue #50. Adds
.group/conversation-turnto chatgpt turns selectors.