fix: update chatgpt selectors for turns (#56)#60
Conversation
|
@codex Please review this PR. If you find no critical issues, reply with "LGTM". If you find critical issues, describe them clearly. |
Automated ReviewLGTM from automated reviewer. Please still verify both ChatGPT and Claude manually before merge. Checklist
Findings
Verdict: |
1 similar comment
Automated ReviewLGTM from automated reviewer. Please still verify both ChatGPT and Claude manually before merge. Checklist
Findings
Verdict: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f53dae393
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| '.conversation-turn', | ||
| '[data-role]', |
There was a problem hiding this comment.
When ChatGPT's updated DOM only exposes .conversation-turn/data-role (the scenario these entries target), these additions only affect diagnostics/probes: readChatGPTTurns() and getChatGPTMessageTurns() still hard-code their selector lists, and mapChatGPTTurn() still never reads data-role. As a result, the extension will still miss those turns or classify every turn without data-message-author-role as assistant, so the reported ChatGPT selector breakage remains unfixed. Please add the new selectors and role attribute to the runtime parser, not just the selector registry.
Useful? React with 👍 / 👎.
2 participants
Closes #56. Updates selectors for ChatGPT to handle new turn attributes and classes.