fix: expand claude selectors for issue #57#61
Conversation
|
@codex Please review this PR. If you find no critical issues, reply with "LGTM". If you find critical issues, describe them clearly. |
Automated ReviewAutomated reviewer found issues that need human attention before merge. Checklist
Findings
Verdict: |
1 similar comment
Automated ReviewAutomated reviewer found issues that need human attention before merge. Checklist
Findings
Verdict: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14c5ac1583
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "div[data-is-user='true']", | ||
| ".user-message", | ||
| "[class*='user-message']" |
There was a problem hiding this comment.
In the Claude DOM case this PR is targeting, where messages are only identifiable via data-is-user or the new message classes, adding entries here does not change runtime turn parsing: selectors.json is loaded for selector probes, but readClaudeTurns() still uses the hard-coded selector lists in getClaudeUserTurns() / getClaudeAssistantCandidates() in content.js, which omit these new selectors. This can make diagnostics show healthy selector hits while the extension still fails to build the Claude turn tree, so the reported issue remains unfixed unless the parser lists are updated as well.
Useful? React with 👍 / 👎.
2 participants
Closes #57. Expand generic selectors for Claude UI update.