chore: enable predeclared and govet linters (#297)

G-Rath · web-flow · commit 68b0e313dcfa · 2025-04-03T15:34:17.000+13:00
* chore: enable `predeclared` and `govet` linters

* chore: add a `return` to make `staticcheck` linter
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -23,8 +23,6 @@ linters:
     - tenv             # Deprecated
     - varnamelen       # maybe later
     - wsl              # disagree with, for now
-    - predeclared
-    - govet
 
 linters-settings:
   depguard:
diff --git a/pkg/database/api_test.go b/pkg/database/api_test.go
@@ -79,6 +79,9 @@ func TestNewAPIDB_Valid(t *testing.T) {
 
 	if db == nil {
 		t.Fatalf("NewAPIDB() db unexpectedly nil")
+
+		// this is required currently to make the staticcheck linter
+		return
 	}
 
 	if !reflect.DeepEqual(db.BaseURL, u) {

Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,9 @@ func TestNewAPIDB_Valid(t *testing.T) {`
`79`	`79`
`80`	`80`	`if db == nil {`
`81`	`81`	`t.Fatalf("NewAPIDB() db unexpectedly nil")`
	`82`	`+`
	`83`	`+ // this is required currently to make the staticcheck linter`
	`84`	`+ return`
`82`	`85`	`}`
`83`	`86`
`84`	`87`	`if !reflect.DeepEqual(db.BaseURL, u) {`