fix: update "last modified" properly

Author: G-Rath

pkg/database/smart.go

@@ -85,11 +85,11 @@ func (db *SmartDB) writeZipFile(zipFile *zip.File) error {
 	return err
 }
 
-func (db *SmartDB) populateFromZip() error {
+func (db *SmartDB) populateFromZip() (*time.Time, error) {
 	err := os.MkdirAll(db.cachePath(), 0744)
 
 	if err != nil {
-		return err
+		return nil, err
 	}
 
 	zdb := &ZipDB{
@@ -102,12 +102,12 @@ func (db *SmartDB) populateFromZip() error {
 	body, err := zdb.fetchZip()
 
 	if err != nil {
-		return err
+		return nil, err
 	}
 
 	zipReader, err := zip.NewReader(bytes.NewReader(body), int64(len(body)))
 	if err != nil {
-		return fmt.Errorf("could not read OSV database archive: %w", err)
+		return nil, fmt.Errorf("could not read OSV database archive: %w", err)
 	}
 
 	// Read each file from the archive and write it to the db directory
@@ -123,11 +123,17 @@ func (db *SmartDB) populateFromZip() error {
 		err = db.writeZipFile(zipFile)
 
 		if err != nil {
-			return err
+			return nil, err
 		}
 	}
 
-	return nil
+	tim, err := time.Parse(http.TimeFormat, zdb.UpdatedAt)
+
+	if err != nil {
+		return nil, err
+	}
+
+	return &tim, nil
 }
 
 type modifiedIDRow struct {
@@ -262,18 +268,17 @@ func (db *SmartDB) load() error {
 
 	// (re)initialize the database using the zip file
 	if err != nil {
-		err = db.populateFromZip()
+		newLastModified, err := db.populateFromZip()
 
 		if err != nil {
 			return err
 		}
 
-		// update the last modified time to now
-		lastModified = time.Now()
+		lastModified = *newLastModified
 	}
 
 	// update any advisories that have changed since the last modified timestamp
-	err = db.updateModifiedAdvisories(lastModified)
+	err = db.updateModifiedAdvisories(time.Now())
 	if err != nil {
 		return err
 	}