Ensure access path is from FSharp namespace in VirtualCallAnalyzer (#87)

* Ensure access path is from FSharp namespace in VirtualCallAnalyzer

* Add changelog entry

Author: nojaf

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.12.1 - 2024-01-08
+
+### Fixed
+* VirtualCall analyzer suggests quickfix on Collections.Generic.List. [#86](https://github.com/G-Research/fsharp-analyzers/issues/86)
+
 ## 0.12.0 - 2024-11-20
 
 ### Changed

global.json

@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "8.0.300",
+    "version": "8.0.400",
     "allowPrerelease": true,
     "rollForward": "latestMinor"
   }

src/FSharp.Analyzers/VirtualCallAnalyzer.fs

@@ -29,17 +29,27 @@ let (|CoerceToSeq|_|) (includeFromSet : bool) (expr : FSharpExpr) =
                     StringComparison.Ordinal
                 )
             then
-                e.Type.TypeDefinition.AbbreviatedType.TypeDefinition.LogicalName
+                Some e.Type.TypeDefinition.AbbreviatedType.TypeDefinition.LogicalName
+            elif
+                (let accessPath = e.Type.TypeDefinition.AccessPath in
+
+                 accessPath = "Microsoft.FSharp.Collections"
+                 || accessPath = "Microsoft.FSharp.Core")
+            then
+                Some e.Type.TypeDefinition.LogicalName
             else
-                e.Type.TypeDefinition.LogicalName
-
-        match coercedValueTypeName with
-        | "[]`1"
-        | "array`1" -> Some "Array"
-        | "list`1"
-        | "List`1" -> Some "List"
-        | "Set`1" when includeFromSet -> Some "Set"
-        | _ -> None
+                None
+
+        coercedValueTypeName
+        |> Option.bind (fun coercedValueTypeName ->
+            match coercedValueTypeName with
+            | "[]`1"
+            | "array`1" -> Some "Array"
+            | "list`1"
+            | "List`1" -> Some "List"
+            | "Set`1" when includeFromSet -> Some "Set"
+            | _ -> None
+        )
     | _ -> None
 
 let seqFuncsWithEquivalentsInAllCollections =

tests/FSharp.Analyzers.Tests/Common.fs

@@ -8,7 +8,7 @@ open NUnit.Framework
 open FSharp.Analyzers.SDK
 
 [<Literal>]
-let framework = "net7.0"
+let framework = "net8.0"
 
 let shouldUpdateBaseline () =
     Environment.GetEnvironmentVariable "TEST_UPDATE_BSL"

tests/FSharp.Analyzers.Tests/data/virtualcall/negative/SystemCollectionsGenericList.fs

@@ -0,0 +1,4 @@
+module C
+
+let list = System.Collections.Generic.List<int>()
+let h = Seq.head list