[MERGE] Merge branch '769-loadRecordsFromGdx-breaking-change' into 'develop'

Revert the commit that causes a breaking change in the behaviour of...

Closes #769

See merge request devel/gamspy!744

Author: mabdullahsoyturk

changelog/769.bugfix.rst

@@ -0,0 +1 @@
+Revert the commit that causes a breaking change in the behaviour of container.loadRecordsFromGdx. If a symbol in the gdx file does not already exist in the container, create it automatically.

ci/.cli.yml

@@ -141,6 +141,8 @@ wei-cli-3.14:
   variables:
     UV_PYTHON_INSTALL_DIR: "$CI_PROJECT_DIR/.uv_pythons"
   script:
+    - Expand-Archive -Path uv_toolchain.zip -DestinationPath . -Force
+    - Expand-Archive -Path uv_bin.zip -DestinationPath . -Force
     - $env:Path = "$CI_PROJECT_DIR\.uv_bin;$env:Path"
     - uv venv .venv --python 3.14
     - .venv\Scripts\Activate.ps1
@@ -159,6 +161,8 @@ wei-cli-3.10:
   variables:
     UV_PYTHON_INSTALL_DIR: "$CI_PROJECT_DIR/.uv_pythons"
   script:
+    - Expand-Archive -Path uv_toolchain.zip -DestinationPath . -Force
+    - Expand-Archive -Path uv_bin.zip -DestinationPath . -Force
     - $env:Path = "$CI_PROJECT_DIR\.uv_bin;$env:Path"
     - uv venv .venv --python 3.10
     - .venv\Scripts\Activate.ps1

ci/.test-wei.yml

@@ -6,6 +6,8 @@
   variables:
     UV_PYTHON_INSTALL_DIR: "$CI_PROJECT_DIR/.uv_pythons"
   script:
+    - Expand-Archive -Path uv_toolchain.zip -DestinationPath . -Force
+    - Expand-Archive -Path uv_bin.zip -DestinationPath . -Force
     - $env:Path = "$CI_PROJECT_DIR\.uv_bin;$env:Path"
     - uv venv .venv --python $env:PYTHON_VERSION
     - .venv\Scripts\Activate.ps1
@@ -20,6 +22,8 @@ wei-test-3.14:
   variables:
     PYTHON_VERSION: "3.14"
   script:
+    - Expand-Archive -Path uv_toolchain.zip -DestinationPath . -Force
+    - Expand-Archive -Path uv_bin.zip -DestinationPath . -Force
     - $env:Path = "$CI_PROJECT_DIR\.uv_bin;$env:Path"
     - uv venv .venv --python 3.14
     - .venv\Scripts\Activate.ps1
@@ -78,6 +82,8 @@ wei-test-3.10:
   variables:
     UV_PYTHON_INSTALL_DIR: "$CI_PROJECT_DIR/.uv_pythons"
   script:
+    - Expand-Archive -Path uv_toolchain.zip -DestinationPath . -Force
+    - Expand-Archive -Path uv_bin.zip -DestinationPath . -Force
     - $env:Path = "$CI_PROJECT_DIR\.uv_bin;$env:Path"
     - uv venv .venv --python $env:PYTHON_VERSION
     - .venv\Scripts\Activate.ps1
@@ -104,6 +110,8 @@ wei-engine-3.10:
   variables:
     UV_PYTHON_INSTALL_DIR: "$CI_PROJECT_DIR/.uv_pythons"
   script:
+    - Expand-Archive -Path uv_toolchain.zip -DestinationPath . -Force
+    - Expand-Archive -Path uv_bin.zip -DestinationPath . -Force
     - $env:Path = "$CI_PROJECT_DIR\.uv_bin;$env:Path"
     - uv venv .venv --python $env:PYTHON_VERSION
     - .venv\Scripts\Activate.ps1

ci/.toolchain.yml

@@ -49,9 +49,13 @@ setup-wei-toolchain:
     - $env:Path = "$CI_PROJECT_DIR\.uv_bin;$env:Path"
     - echo "Downloading Python toolchain for Windows..."
     - uv python install 3.10 3.11 3.12 3.13 3.14
+    # Compress the folder manually to bypass GitLab Runner's symlink/junction issues
+    - echo "Compressing toolchain to avoid 'Incorrect function' artifact error..."
+    - Compress-Archive -Path "$CI_PROJECT_DIR\.uv_pythons" -DestinationPath "$CI_PROJECT_DIR\uv_toolchain.zip" -Force
+    - Compress-Archive -Path "$CI_PROJECT_DIR\.uv_bin" -DestinationPath "$CI_PROJECT_DIR\uv_bin.zip" -Force
   artifacts:
     name: "toolchain-windows"
     paths:
-      - .uv_pythons/
-      - .uv_bin/
+      - uv_toolchain.zip
+      - uv_bin.zip
     expire_in: 2 hours

src/gamspy/_backend/backend.py

@@ -222,9 +222,7 @@ def load_records(self, relaxed_domain_mapping: bool = False):
             symbols = filtered_names
 
         if len(symbols) != 0:
-            self.container._load_records_from_gdx(
-                self.container._gdx_out, symbols, create_if_not_declared=True
-            )
+            self.container._load_records_from_gdx(self.container._gdx_out, symbols)
             self.make_unmodified(symbols)
 
         if relaxed_domain_mapping:

src/gamspy/_container.py

@@ -588,7 +588,6 @@ def _generate_gams_string(
     def _filter_load_symbols(
         self,
         symbol_names: dict[str, str] | list[str],
-        create_if_not_declared: bool = False,
     ) -> dict[str, str] | list[str]:
         if isinstance(symbol_names, list):
             names = []
@@ -598,12 +597,7 @@ def _filter_load_symbols(
                     if not isinstance(symbol, gt.Alias) and symbol.synchronize:
                         names.append(name)
                 else:
-                    if create_if_not_declared:
-                        names.append(name)
-                    else:
-                        raise ValidationError(
-                            f"Cannot load records of `{name}` because it does not exist in the container."
-                        )
+                    names.append(name)
 
             return names
 
@@ -619,13 +613,7 @@ def _filter_load_symbols(
 
         return mapping
 
-    def _load_records_from_gdx(
-        self,
-        load_from: str,
-        names: Iterable[str],
-        *,
-        create_if_not_declared: bool = False,
-    ) -> None:
+    def _load_records_from_gdx(self, load_from: str, names: Iterable[str]) -> None:
         self._temp_container.read(load_from, names)
         original_state = self._options.miro_protect
         self._options.miro_protect = False
@@ -636,12 +624,7 @@ def _load_records_from_gdx(
                 self[name].records = updated_records
                 self[name].domain_labels = self[name].domain_names
             else:
-                if create_if_not_declared:
-                    self._read(load_from, [name])
-                else:
-                    raise ValidationError(
-                        f"Cannot load records of `{name}` because it does not exist in the container."
-                    )
+                self._read(load_from, [name])
 
         self._options.miro_protect = original_state
         self._temp_container.data = {}
@@ -989,54 +972,28 @@ def loadRecordsFromGdx(
         if isinstance(load_from, Path):
             load_from = str(load_from.resolve())
 
-        create_if_not_declared = symbol_names is None
         if symbol_names is None:
             # If no symbol names are given, all records in the gdx should be loaded
             symbol_names = utils._get_symbol_names_from_gdx(
                 self.system_directory, load_from
             )
             self._add_statement(f"$declareAndLoad {load_from}")
-            symbol_names = self._filter_load_symbols(
-                symbol_names,  # type: ignore
-                create_if_not_declared,
-            )
-            self._load_records_from_gdx(
-                load_from, symbol_names, create_if_not_declared=create_if_not_declared
-            )
+            symbol_names = self._filter_load_symbols(symbol_names)  # type: ignore
+            self._load_records_from_gdx(load_from, symbol_names)
             self._synch_with_gams()
             return
 
-        if isinstance(symbol_names, list):
-            symbol_names = self._filter_load_symbols(
-                symbol_names, create_if_not_declared
-            )
-            self._add_statement(f"$gdxIn {load_from}")
-            symbols_str = " ".join(symbol_names)
-            self._add_statement(f"$loadDC {symbols_str}")
-            self._add_statement("$gdxIn")
-        elif isinstance(symbol_names, dict):
-            symbol_names = self._filter_load_symbols(
-                symbol_names, create_if_not_declared
-            )
-            self._add_statement(f"$gdxIn {load_from}")
-            symbols_str = " ".join(
-                [f"{value}={key}" for key, value in symbol_names.items()]  # type: ignore
-            )
-            self._add_statement(f"$loadDC {symbols_str}")
-            self._add_statement("$gdxIn")
+        if isinstance(symbol_names, (list, dict)):
+            symbol_names = self._filter_load_symbols(symbol_names)
         else:
             raise TypeError("`symbol_names` must be either a list or a dictionary.")
 
-        self._options._debug_options["gdx"] = self._gdx_out
-        self._options._debug_options["gdxSymbols"] = "newOrChanged"
-        self._synch_with_gams()
-
         if isinstance(symbol_names, dict):
             self._load_records_with_rename(load_from, symbol_names)
         else:
-            self._load_records_from_gdx(
-                load_from, symbol_names, create_if_not_declared=create_if_not_declared
-            )
+            self._load_records_from_gdx(load_from, symbol_names)
+
+        self._synch_with_gams()
 
     def addGamsCode(self, gams_code: str) -> None:
         """

src/gamspy/_miro.py

@@ -41,9 +41,7 @@ def load_miro_symbol_records(container: Container):
             for name in container._miro_input_symbols
             if not container[name]._already_loaded
         ]
-        container._load_records_from_gdx(
-            MIRO_GDX_IN, names, create_if_not_declared=True
-        )
+        container._load_records_from_gdx(MIRO_GDX_IN, names)
         for name in names:
             symbol = container[name]
             symbol._already_loaded = True
@@ -56,9 +54,7 @@ def load_miro_symbol_records(container: Container):
 
     # Load records of miro output symbols
     if MIRO_GDX_OUT and container._miro_output_symbols:
-        container._load_records_from_gdx(
-            MIRO_GDX_OUT, container._miro_output_symbols, create_if_not_declared=True
-        )
+        container._load_records_from_gdx(MIRO_GDX_OUT, container._miro_output_symbols)
 
     for name in container._miro_input_symbols + container._miro_output_symbols:
         container[name].modified = False

tests/unit/test_container.py

@@ -346,11 +346,13 @@ def test_loadRecordsFromGdxSync(tmp_path):
     assert i.records is None, i.records
     assert j.toList() == ["0", "1", "2"], j.toList()
 
+    # load a symbol that does not exist in the container
     m = gp.Container()
     i = gp.Set(m, "i")
     i.synchronize = False
-    with pytest.raises(ValidationError):
-        m.loadRecordsFromGdx(tmp_file, symbol_names=["i", "j"])
+    m.loadRecordsFromGdx(tmp_file, symbol_names=["i", "j"])
+    assert list(m.data.keys()) == ["i", "j"]
+    assert m["j"].toList() == ["0", "1", "2"]
 
     j = gp.Set(m, "j")
     m.loadRecordsFromGdx(tmp_file, symbol_names=["i", "j"])