Add postgres message queue (pgmq) publisher and consumer#1654
Merged
Conversation
doxthree
reviewed
Apr 28, 2026
doxthree
reviewed
Apr 28, 2026
pstadermann
commented
Apr 28, 2026
cavus700
reviewed
Apr 28, 2026
cavus700
reviewed
Apr 28, 2026
cavus700
reviewed
Apr 28, 2026
prskr
reviewed
Apr 29, 2026
prskr
reviewed
Apr 29, 2026
prskr
reviewed
Apr 29, 2026
prskr
reviewed
Apr 29, 2026
Contributor
|
I think you're missing a |
chris3240
force-pushed
the
feature/add-pgmq
branch
from
bd7395e to
9b9f5a9
Compare
rngcntr
reviewed
May 4, 2026
GermanCoding
force-pushed
the
feature/add-pgmq
branch
from
a28ea0f to
be7fecd
Compare
doxthree
force-pushed
the
feature/add-pgmq
branch
from
d99d32a to
dd9d745
Compare
GermanCoding
force-pushed
the
feature/add-pgmq
branch
2 times, most recently
from
a15f820 to
98bf702
Compare
Contributor
Extension is implemented |
rngcntr
reviewed
May 13, 2026
cavus700
reviewed
May 13, 2026
prskr
reviewed
May 13, 2026
prskr
reviewed
May 13, 2026
prskr
reviewed
May 13, 2026
prskr
reviewed
May 13, 2026
prskr
reviewed
May 13, 2026
prskr
reviewed
May 13, 2026
prskr
reviewed
May 13, 2026
prskr
reviewed
May 13, 2026
prskr
reviewed
May 13, 2026
prskr
reviewed
May 13, 2026
prskr
reviewed
May 13, 2026
prskr
reviewed
May 13, 2026
prskr
reviewed
May 13, 2026
prskr
reviewed
May 13, 2026
| await producer.StopAsync(); | ||
| } | ||
|
|
||
| [Fact(Timeout = 50000)] |
Contributor
There was a problem hiding this comment.
question: why is this timeout 50s when the CancellationTokenSource has a deadline after 5s?
There was a problem hiding this comment.
The tests use a Postgres Fixture with a testcontainer. This needs to be setup once for all tests, but this is slow: We tested this to take up to ~30s for the first test. As the test order is not guaranteed, any test may need to set up this fixture, thus requiring a rather long timeout.
(The extra ~20s are because CI is sometimes slower than a local machine, so extra headroom)
prskr
approved these changes
May 13, 2026
Contributor
prskr
left a comment
prskr
left a comment
There was a problem hiding this comment.
LGTM, a few nits and questions, but nothing urgent that would block the merge
GermanCoding
changed the title
pstadermann
force-pushed
the
feature/add-pgmq
branch
from
532f66d to
089f1a1
Compare
Alex-Kum
force-pushed
the
feature/add-pgmq
branch
3 times, most recently
from
f66f243 to
7838347
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.