Add additional settings#239
Merged
Merged
Conversation
Member
lennartdohmann
commented
Aug 26, 2025
- Control scan timeout
- Control usage of cache
- Control usage of hash lookup
- Control scan timeout - Control usage of cache - Control usage of hash lookup
2985dca to
f5620a2
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds additional configuration settings to control the VaaS (Virus-as-a-Service) scanning behavior, specifically allowing administrators to configure scan timeout, cache usage, and hash lookup functionality.
- Adds three new configuration options: timeout, cache, and hash lookup settings
- Updates the admin settings interface to include input fields for the new options
- Implements backend support for storing and retrieving the new configuration values
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| templates/admin.php | Adds UI elements for timeout, cache, and hash lookup settings |
| src/admin-settings.js | Implements frontend logic to handle new settings and API calls |
| lib/Settings/VaasAdmin.php | Provides default values for new settings in the admin form |
| lib/Service/VerdictService.php | Updates VaasOptions configuration to use the new settings |
| lib/Controller/SettingsController.php | Adds backend validation and storage for new settings |
| css/style.css | Adds styling for checkbox inputs in the settings table |
| appinfo/routes.php | Adds new API routes for retrieving cache and hash lookup settings |
| src/files-action.js | Adds try-catch error handling for file scanning |
| tests/bats/functionality-*.bats | Updates test setup and removes unnecessary Docker commands |
| Makefile | Adds composer install to local target |
| .devcontainer/devcontainer.json | Updates VS Code extensions configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lennartdohmann
added a commit
that referenced
this pull request
Aug 28, 2025
* fix: correct syntax error in ScanService.php for constant declaration for PHP < 8.3 (#227) * chore(deps): update dependency webpack-dev-server to v5.2.2 (#225) Co-authored-by: Renovate Bot <renovate-bot@gdata.de> * chore(deps): update all non-major dependencies (#231) Co-authored-by: Renovate Bot <renovate-bot@gdata.de> * chore(deps): update dependency psalm/phar to v6.13.0 (#232) Co-authored-by: Renovate Bot <renovate-bot@gdata.de> * chore(deps): update all non-major dependencies (#233) Co-authored-by: Renovate Bot <renovate-bot@gdata.de> * Add a quicker way for development with a local Nextcloud server and the app code changeable inside this server (#234) * Add Nextclouds worklfow templates and apply Nextcloud coding style (#235) * Add maximum scan size setting for file uploads (#236) * Devcontainer and Workflow Performance (#237) - Faster local development in devcontainer - Add Make stages for local fast developing as well as unit and bats tests - Remove unmaintained files from old debugging sessions` - Cleanup unused files and bundle utility scripts * Settings improvements (#238) - Add button to test current vaas configuration - Rename app settings to be more intuitive * Add additional settings (#239) - Control scan timeout - Control usage of cache - Control usage of hash lookup * Refactor logging messages and remove redundant debug statements (#240) * Update README with development environment setup instructions (#241) * Remove unused settings (#242) - Malicious file notifications summary - Scan only new files * Add make target for production like local setup (#243) * Outsource file scan actions (#244) --------- Co-authored-by: vaas-bot <108060048+ata-no-one@users.noreply.github.com> Co-authored-by: Renovate Bot <renovate-bot@gdata.de>
lennartdohmann
added a commit
that referenced
this pull request
Aug 28, 2025
* fix: correct syntax error in ScanService.php for constant declaration for PHP < 8.3 (#227) * Add a quicker way for development with a local Nextcloud server and the app code changeable inside this server (#234) * Add Nextclouds worklfow templates and apply Nextcloud coding style (#235) * Add maximum scan size setting for file uploads (#236) * Devcontainer and Workflow Performance (#237) - Faster local development in devcontainer - Add Make stages for local fast developing as well as unit and bats tests - Remove unmaintained files from old debugging sessions` - Cleanup unused files and bundle utility scripts * Settings improvements (#238) - Add button to test current vaas configuration - Rename app settings to be more intuitive * Add additional settings (#239) - Control scan timeout - Control usage of cache - Control usage of hash lookup * Refactor logging messages and remove redundant debug statements (#240) * Update README with development environment setup instructions (#241) * Remove unused settings (#242) - Malicious file notifications summary - Scan only new files * Add make target for production like local setup (#243) * Outsource file scan actions (#244)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.