Skip to content

Commit 3abc1e1

Browse files
committed
refactor(phone): normalize phone lookup in recruit services
1 parent 3453530 commit 3abc1e1

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

src/main/java/inha/gdgoc/domain/recruit/member/service/RecruitMemberService.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public void addRecruitMember(ApplicationRequest applicationRequest) {
5959

6060
@Transactional
6161
public void addRecruitMemberMemo(RecruitMemberMemoRequest recruitMemberMemoRequest) {
62-
String cleanPhone = recruitMemberMemoRequest.getPhoneNumber().replaceAll("[^0-9]", "");
62+
String cleanPhone = normalizePhoneNumber(recruitMemberMemoRequest.getPhoneNumber());
6363
if (recruitMemberRepository.existsByPhoneNumber(cleanPhone)) {
6464
throw new RecruitMemberException(RECRUIT_MEMBER_ALREADY_APPLIED);
6565
}
@@ -74,7 +74,7 @@ public CheckStudentIdResponse isRegisteredStudentId(String studentId) {
7474
}
7575

7676
public CheckPhoneNumberResponse isRegisteredPhoneNumber(String phoneNumber) {
77-
String cleanPhone = phoneNumber.replaceAll("[^0-9]", "");
77+
String cleanPhone = normalizePhoneNumber(phoneNumber);
7878
boolean exists = recruitMemberRepository.existsByPhoneNumber(cleanPhone);
7979

8080
return new CheckPhoneNumberResponse(exists);
@@ -116,4 +116,8 @@ public Page<RecruitMember> searchMembersByNamePage(String name, Pageable pageabl
116116
return recruitMemberRepository.findByNameContainingIgnoreCase(name, pageable);
117117
}
118118

119+
private String normalizePhoneNumber(String phoneNumber) {
120+
return phoneNumber.replaceAll("[^0-9]", "");
121+
}
122+
119123
}

src/main/java/inha/gdgoc/domain/user/service/UserService.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,4 +68,5 @@ private String maskEmail(String email) {
6868
+ localPart.substring(localPart.length() - endLen)
6969
+ domainPart;
7070
}
71-
}
71+
72+
}

0 commit comments

Comments
 (0)