Skip to content

feat: allow leads to access core application admin APIs #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CSE-Shaco merged 1 commit into from
Mar 12, 2026
Merged

feat: allow leads to access core application admin APIs #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions ...main/java/inha/gdgoc/domain/admin/recruit/core/controller/RecruitCoreAdminController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,14 @@
@RequiredArgsConstructor
public class RecruitCoreAdminController {

private static final String ORGANIZER_OR_HR_LEAD_RULE =
private static final String LEAD_OR_HIGHER_RULE =
"@accessGuard.check(authentication,"
+ " T(inha.gdgoc.global.security.AccessGuard$AccessCondition).atLeast("
+ "T(inha.gdgoc.domain.user.enums.UserRole).ORGANIZER),"
+ " T(inha.gdgoc.global.security.AccessGuard$AccessCondition).of("
+ "T(inha.gdgoc.domain.user.enums.UserRole).LEAD,"
+ " T(inha.gdgoc.domain.user.enums.TeamType).HR))";
+ "T(inha.gdgoc.domain.user.enums.UserRole).LEAD))";

private final RecruitCoreAdminService adminService;

@PreAuthorize("hasAnyRole('ADMIN','ORGANIZER')")
@PreAuthorize(LEAD_OR_HIGHER_RULE)
@GetMapping
public RecruitCoreApplicationPageResponse list(
@RequestParam String session,
Expand All @@ -66,13 +63,13 @@ public RecruitCoreApplicationPageResponse list(
);
}

@PreAuthorize(ORGANIZER_OR_HR_LEAD_RULE)
@PreAuthorize(LEAD_OR_HIGHER_RULE)
@GetMapping("/{applicationId}")
public ResponseEntity<RecruitCoreApplicantDetailResponse> detail(@PathVariable Long applicationId) {
return ResponseEntity.ok(adminService.getApplicationDetail(applicationId));
}

@PreAuthorize(ORGANIZER_OR_HR_LEAD_RULE)
@PreAuthorize(LEAD_OR_HIGHER_RULE)
@PostMapping("/{applicationId}/accept")
public ResponseEntity<RecruitCoreApplicationDecisionResponse> accept(
@AuthenticationPrincipal CustomUserDetails reviewer,
Expand All @@ -84,7 +81,7 @@ public ResponseEntity<RecruitCoreApplicationDecisionResponse> accept(
return ResponseEntity.ok(response);
}

@PreAuthorize(ORGANIZER_OR_HR_LEAD_RULE)
@PreAuthorize(LEAD_OR_HIGHER_RULE)
@PostMapping("/{applicationId}/reject")
public ResponseEntity<RecruitCoreApplicationDecisionResponse> reject(
@AuthenticationPrincipal CustomUserDetails reviewer,
Expand Down
Loading