Skip to content

Commit 64869ee

Browse files
committed
Edit the report form, add direct link to translations repository
1 parent 8f6447d commit 64869ee

3 files changed

Lines changed: 28 additions & 36 deletions

File tree

autoload/Log.gd

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -54,31 +54,23 @@ func write(level: int, properties: Dictionary, message: String) -> void:
5454
_log_lines.append(line)
5555
return
5656
var props = godot_dict_to_js_obj(properties)
57+
@warning_ignore_start("unsafe_property_access")
58+
@warning_ignore_start("unsafe_method_access")
5759
match (level):
5860
LEVEL.FATAL:
59-
@warning_ignore("unsafe_property_access")
60-
@warning_ignore("unsafe_method_access")
6161
GDQUEST.log.fatal(props, message)
6262
LEVEL.ERROR:
63-
@warning_ignore("unsafe_property_access")
64-
@warning_ignore("unsafe_method_access")
6563
GDQUEST.log.error(props, message)
6664
LEVEL.WARN:
67-
@warning_ignore("unsafe_property_access")
68-
@warning_ignore("unsafe_method_access")
6965
GDQUEST.log.warn(props, message)
7066
LEVEL.INFO:
71-
@warning_ignore("unsafe_property_access")
72-
@warning_ignore("unsafe_method_access")
7367
GDQUEST.log.info(props, message)
7468
LEVEL.DEBUG:
75-
@warning_ignore("unsafe_property_access")
76-
@warning_ignore("unsafe_method_access")
7769
GDQUEST.log.debug(props, message)
7870
_:
79-
@warning_ignore("unsafe_property_access")
80-
@warning_ignore("unsafe_method_access")
8171
GDQUEST.log.trace(props, message)
72+
@warning_ignore_restore("unsafe_property_access")
73+
@warning_ignore_restore("unsafe_method_access")
8274

8375

8476
func trace(properties: Dictionary, message: String) -> void:
@@ -142,18 +134,18 @@ func trim_if_over_limit(max_kilo_bytes := 1000) -> bool:
142134

143135
# Logs system info if the log is empty. Safe to call in all environments
144136
func log_system_info_if_log_is_empty(additional_data := { }) -> void:
137+
@warning_ignore_start("unsafe_method_access")
138+
@warning_ignore_start("unsafe_property_access")
145139
if not _js_available:
146140
if additional_data.size() > 0:
147141
trace(additional_data, 'INIT')
148142
elif additional_data.size() > 0:
149143
var props = godot_dict_to_js_obj(additional_data)
150-
@warning_ignore("unsafe_method_access")
151-
@warning_ignore("unsafe_property_access")
152144
GDQUEST.log.logSystemInfoIfLogIsEmpty(props)
153145
else:
154-
@warning_ignore("unsafe_method_access")
155-
@warning_ignore("unsafe_property_access")
156146
GDQUEST.log.logSystemInfoIfLogIsEmpty()
147+
@warning_ignore_restore("unsafe_method_access")
148+
@warning_ignore_restore("unsafe_property_access")
157149

158150

159151
func godot_dict_to_js_obj(properties: Dictionary):
@@ -177,7 +169,6 @@ func get_info() -> Dictionary:
177169
"video_vendor": RenderingServer.get_video_adapter_vendor(),
178170
"screen_size": DisplayServer.screen_get_size(),
179171
"screen_dpi": DisplayServer.screen_get_dpi(),
180-
"cores": OS.get_processor_count(),
181172
"locale": OS.get_locale(),
182173
"joypad": Input.get_joy_name(joypad_index) if is_joypad else "",
183174
}

ui/components/popups/ReportFormPopup.gd

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ func _on_meta_clicked(data) -> void:
3434
var string_data: String = data
3535
if string_data.begins_with("https://"):
3636
OS.shell_open(string_data)
37-
elif string_data == "download":
38-
Log.download()
3937

4038

4139
func _notification(what: int) -> void:

ui/components/popups/ReportFormPopup.tscn

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
[gd_scene format=3 uid="uid://dxc8hjg7r2d7w"]
22

33
[ext_resource type="Script" uid="uid://bltsl5n1mk6ed" path="res://ui/components/popups/ReportFormPopup.gd" id="1"]
4-
[ext_resource type="StyleBox" path="res://ui/theme/focus_accent.tres" id="3"]
5-
[ext_resource type="StyleBox" path="res://ui/theme/button_outline_large_normal.tres" id="4"]
6-
[ext_resource type="StyleBox" path="res://ui/theme/panel_normal.tres" id="5"]
7-
[ext_resource type="StyleBox" path="res://ui/theme/button_outline_large_accent.tres" id="6"]
4+
[ext_resource type="StyleBox" uid="uid://bsrxxsifsyu4k" path="res://ui/theme/focus_accent.tres" id="3"]
5+
[ext_resource type="StyleBox" uid="uid://b45mlqutqarjn" path="res://ui/theme/button_outline_large_normal.tres" id="4"]
6+
[ext_resource type="StyleBox" uid="uid://lvuws1hlca6y" path="res://ui/theme/panel_normal.tres" id="5"]
7+
[ext_resource type="StyleBox" uid="uid://dhdt5bfr2nel5" path="res://ui/theme/button_outline_large_accent.tres" id="6"]
88
[ext_resource type="Theme" uid="uid://b03mml1yyrchy" path="res://ui/theme/gdscript_app_theme.tres" id="7"]
99

1010
[node name="ReportFormPopup" type="CanvasLayer" unique_id=1915005343]
@@ -67,33 +67,36 @@ size_flags_horizontal = 4
6767
layout_mode = 2
6868
size_flags_vertical = 3
6969
bbcode_enabled = true
70-
text = "If you face an issue in the app, please click the link below to report it on GitHub:
70+
text = "Use the link below to report a bug or an error in a lesson on GitHub:
7171
7272
[center][b][url=https://github.com/GDQuest/learn-gdscript/issues]GitHub.com > GDQuest > learn-gdscript > Issues[/url][/b][/center]
7373
74-
On that page, you can report any issues, whether something's not working or there's an error in a lesson.
74+
[font=res://ui/theme/fonts/font_title.tres]Missing translations[/font]
7575
76-
You can generate a log to help us identify the problem. To do so, click here: [b][url=download]generate error log[/url][/b].
76+
If some text in the app is not translated into your language, it is most likely because the translation for your language is incomplete. Our translations are maintained by volunteers and not every language is fully covered yet.
7777
78-
Please drag and drop the generated file onto your issue on GitHub to attach it.
78+
If you want to help translate the app, you can find instructions on how to contribute on this page:
7979
80-
[font=res://ui/theme/fonts/font_title.tres]What's GitHub[/font]
80+
[center][b][url=https://github.com/GDQuest/learn-gdscript-translations/#readme]GitHub.com > GDQuest > learn-gdscript-translations[/url][/b][/center]
8181
82-
GitHub is an online platform to host and manage open-source projects like the GDScript Learn app. It helps developers organize their work and collaborate online.
82+
[font=res://ui/theme/fonts/font_title.tres]What is GitHub[/font]
8383
84-
You can use GitHub to study the source code of many open projects, report issues, or even contribute code yourself.
84+
GitHub is a website where developers share and work on open-source projects. Open-source means the code is public and anyone can read it, report problems, or help improve it.
85+
86+
This app is open-source, and we currently use GitHub to track bugs and improvements.
8587
8688
[font=res://ui/theme/fonts/font_title.tres]How to report an issue[/font]
8789
88-
1. Click the link above to get to the [i]GitHub Issues[/i] page.
89-
2. Click on the [i]New Issue[/i] button.
90-
3. Fill out the form to tell us more about your problem.
90+
1. Click the first link at the top of this page to go to the [i]GitHub Issues[/i] page.
91+
2. Use the search bar to verify that your issue has not been reported already.
92+
3. Click the [i]New Issue[/i] button.
93+
4. Fill out the form to describe what went wrong.
9194
92-
You will need a GitHub account to do so.
95+
You will need a free GitHub account to do this.
9396
94-
Please add as much relevant information as possible, such as the kind of device you're using to access the app, and maybe attach a screenshot or video clip showcasing the issue.
97+
Please include as much detail as you can, such as what device you are using and what you were doing when the problem happened. A screenshot also helps a lot.
9598
96-
[center]Thank you for contributing to open source![/center]"
99+
[center]Thank you for helping make this app better.[/center]"
97100

98101
[node name="Spacer" type="Control" parent="PanelContainer/Column/Margin/Column" unique_id=673476989]
99102
custom_minimum_size = Vector2(400, 20)

0 commit comments

Comments
 (0)