Skip to content

Commit a669432

Browse files
committed
Fix some non-course warnings
1 parent d17607c commit a669432

7 files changed

Lines changed: 10 additions & 9 deletions

File tree

course/common/GDScriptCodeExample.gd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const CODE_FONT := "res://ui/theme/fonts/font_code.tres"
1010

1111
func _ready() -> void:
1212
if get_theme_font("font").resource_path != CODE_FONT:
13-
add_theme_font_override("font", load(CODE_FONT))
13+
add_theme_font_override("font", load(CODE_FONT) as FontVariation)
1414
Events.font_size_scale_changed.connect(_update_size)
1515
context_menu_enabled = false
1616
shortcut_keys_enabled = false

course/common/Robot.tscn

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1308,6 +1308,7 @@ scale_amount_curve = SubResource("4")
13081308
color_ramp = SubResource("6")
13091309

13101310
[node name="AnimationTree" type="AnimationTree" parent="." unique_id=1562063924]
1311+
callback_mode_discrete = 1
13111312
tree_root = SubResource("15")
13121313
anim_player = NodePath("../AnimationPlayer")
13131314
script = ExtResource("5")

course/common/WrappingNode2D.gd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ func calculate_bounding_rect(sprites: Array) -> Rect2:
1111
return Rect2()
1212

1313
var bounds := Rect2()
14-
for sprite in sprites:
15-
var sprite_rect = sprite.get_rect()
14+
for sprite: Sprite2D in sprites:
15+
var sprite_rect := sprite.get_rect()
1616
sprite_rect.position += sprite.position
1717
bounds = bounds.merge(sprite_rect)
1818
bounds.position += position

course/common/turtle/DrawingTurtle.gd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ func reset() -> void:
119119

120120

121121
# Returns a copy of the polygons the turtle will draw.
122-
func get_polygons() -> Array:
122+
func get_polygons() -> Array[Polygon]:
123123
return _polygons.duplicate()
124124

125125

course/common/turtle/DrawingTurtle.tscn

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,5 @@ texture = ExtResource("1")
2626

2727
[node name="Camera2D" type="Camera2D" parent="." unique_id=1287820734]
2828
top_level = true
29+
enabled = false
2930
position_smoothing_enabled = true

ui/UICore.tscn

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
[ext_resource type="PackedScene" uid="uid://dxc8hjg7r2d7w" path="res://ui/components/popups/ReportFormPopup.tscn" id="5"]
88
[ext_resource type="PackedScene" uid="uid://dcl81wj587ph8" path="res://ui/components/popups/SettingsPopup.tscn" id="6"]
99

10-
[node name="UICore" type="Control" unique_id=1773901745 node_paths=PackedStringArray("_pages", "_loading_screen", "_welcome_screen", "_settings_screen", "_course_screen", "_settings_popup", "_report_form_popup")]
10+
[node name="UICore" type="Control" unique_id=1773901745 node_paths=PackedStringArray("_pages", "_loading_screen", "_welcome_screen", "_course_screen", "_settings_popup", "_report_form_popup")]
1111
process_mode = 3
1212
layout_mode = 3
1313
anchors_preset = 15
@@ -21,7 +21,6 @@ script = ExtResource("4")
2121
_pages = NodePath("Pages")
2222
_loading_screen = NodePath("Pages/LoadingScreen")
2323
_welcome_screen = NodePath("Pages/WelcomeScreen")
24-
_settings_screen = NodePath("Pages/SettingsScreen")
2524
_course_screen = NodePath("Pages/CourseScreen")
2625
_settings_popup = NodePath("SettingsPopup")
2726
_report_form_popup = NodePath("ReportFormPopup")

ui/components/GameView.gd

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,15 @@ func set_paused(value: bool) -> void:
3131
_pause_rect.visible = paused
3232

3333

34-
func use_scene(node: Node, viewport_size: Vector2) -> void:
34+
func use_scene(node: Node, _viewport_size: Vector2) -> void:
3535
_viewport.add_child(node)
3636
move_child(_pause_rect, -1)
37-
_viewport.size = viewport_size
37+
#_viewport.size = viewport_size
3838

3939

4040
func get_viewport_override() -> SubViewport:
4141
return _viewport
4242

4343

4444
func _on_screen_resized() -> void:
45-
_viewport.size = size
45+
pass #_viewport.size = size

0 commit comments

Comments
 (0)